Add more docs #196
Merged
Add more docs #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During upstream overlayfs work, the default for verity xattr was changed to verity=off, so there is no need to specifically have a wey to disable it. All that results in is mount error on kernels that don't support verity=. So, we just support ENABLE_VERITY which implies verity=require, which is the thing we want anyway. Signed-off-by: Alexander Larsson <[email protected]>
alexlarsson
force-pushed
the
more-docs
branch
from
2d88c14
to
3d493f9
Compare
Simplifies the mkcomposefs arguments to always compute digest and by-digest payloads, dropping the --absolute option and related things, as we couldn't think of a usecase for it right now. If we have a more precise usecase later we can add it back in a way that makes sense for the usecase. Signed-off-by: Alexander Larsson <[email protected]>
Signed-off-by: Alexander Larsson <[email protected]>
Signed-off-by: Alexander Larsson <[email protected]>
alexlarsson
force-pushed
the
more-docs
branch
from
3d493f9
to
ce58c0d
Compare
cgwalters
approved these changes
Sep 22, 2023
| } | ||
|
|
||
| if (opt_verity) | ||
| if (opt_verity || opt_digest != NULL) |
There was a problem hiding this comment.
This is one of the bigger changes here right? I think this makes sense...no point in verifying the digest without also doing underlying verity I guess?
There was a problem hiding this comment.
Yeah, i think it would be surprising if you successfully mounted against a particular digest, but then you can still read back modified data from the mount.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the simplify commits that was missing from #195, and updates the docs for mkcomposefs and mount.composefs.