-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meson.build: raise used C standard to C11 #365
Conversation
Some C11 features have been used, but meson.build still specifies c_std=c99, leading to errors on Clang compiler. Fixes: containers#364 Signed-off-by: Yao Zi <[email protected]>
Thanks for this! Actually testing with a somewhat recent clang ( I went ahead and pushed a few additional commits that add a CI check with clang and also fix those errors. |
Also same question as the other PR re licensing: #344 |
864155d
to
2382ad6
Compare
It's okay to me :) |
I pushed some other changes here so I probably shouldn't merge without a 3rd reviewer. |
Especially the ioctl changes need careful review, I only sanity checked this. Hmm I may just mark as draft until we've done that. @ziyao233 what version of clang are you using? It must be an older version that doesn't warn about some gnu-specific stuff? Ohh or maybe the conceptual problem is those are just warnings but in CI we use |
Exactly 18.1.8 and it does throw some warnings, but I didnt come up with a graceful solution to some of them, especially fsverity related things. I decided to split warning fixes into another PR (they are just causing warnings but not error).
Yep
seems a good idea to me |
Some C11 features have been used, but meson.build still specifies c_std=c99, leading to errors on Clang compiler.
Fixes: #364