Skip to content

Commit

Permalink
Add support for runtime service configuration key
Browse files Browse the repository at this point in the history
  • Loading branch information
p12tic committed Mar 8, 2024
1 parent b1e4324 commit 15ae214
Show file tree
Hide file tree
Showing 2 changed files with 69 additions and 0 deletions.
2 changes: 2 additions & 0 deletions podman_compose.py
Original file line number Diff line number Diff line change
Expand Up @@ -983,6 +983,8 @@ async def container_to_args(compose, cnt, detached=True):
platform = cnt.get("platform", None)
if platform is not None:
podman_args.extend(["--platform", platform])
if cnt.get("runtime", None):
podman_args.extend(["--runtime", cnt["runtime"]])

# WIP: healthchecks are still work in progress
healthcheck = cnt.get("healthcheck", None) or {}
Expand Down
67 changes: 67 additions & 0 deletions pytests/test_container_to_args.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
# SPDX-License-Identifier: GPL-2.0

import unittest
from unittest import mock
from podman_compose import container_to_args


def create_compose_mock():
compose = mock.Mock()
compose.project_name = "test_project_name"
compose.dirname = "test_dirname"
compose.container_names_by_service.get = mock.Mock(return_value=None)
compose.prefer_volume_over_mount = False
compose.default_net = None
compose.networks = {}
return compose


def get_minimal_container():
return {
"name": "project_name_service_name1",
"service_name": "service_name",
"image": "busybox",
}


class TestContainerToArgs(unittest.TestCase):
async def test_minimal(self):
c = create_compose_mock()

cnt = get_minimal_container()

args = await container_to_args(c, cnt)
self.assertEqual(
args,
[
"--name=project_name_service_name1",
"-d",
"--net",
"",
"--network-alias",
"service_name",
"busybox",
],
)

async def test_runtime(self):
c = create_compose_mock()

cnt = get_minimal_container()
cnt["runtime"] = "runsc"

args = await container_to_args(c, cnt)
self.assertEqual(
args,
[
"--name=project_name_service_name1",
"-d",
"--net",
"",
"--network-alias",
"service_name",
"--runtime",
"runsc",
"busybox",
],
)

0 comments on commit 15ae214

Please sign in to comment.