podman_compose.py: support "platform" property in the build command #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkueng
force-pushed
the
platform_build_cmd
branch
from
bf1479a
to
d025ad7
Compare
This was already added to container_to_args() in containers#470 which is used for the 'up' and 'run' commands. Definition in the schema: https://github.com/compose-spec/compose-spec/blob/main/schema/compose-spec.json#L329 Signed-off-by: Beat Küng <[email protected]>
p12tic
force-pushed
the
platform_build_cmd
branch
from
d025ad7
to
b3c49df
Compare
|
Rebased and added newsfragment. There are no unit tests for build command and I will not ask to create such tests for now. |
p12tic
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already added to container_to_args() in #470 which is used for the 'up' and 'run' commands.
Definition in the schema: https://github.com/compose-spec/compose-spec/blob/main/schema/compose-spec.json#L329
Should I add a unit test? Are there any for the build command already?