Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #782: add support for http-proxy option of podman #783

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Fix #782: add support for http-proxy option of podman #783

merged 1 commit into from
Mar 9, 2024

Conversation

ChuJiani
Copy link
Contributor

@ChuJiani ChuJiani commented Sep 24, 2023 •
edited
Loading

p12tic
p12tic requested changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@p12tic p12tic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Please add unit tests. See e.g. pytests/test_container_to_args.py for an example.

@ChuJiani
Copy link
Contributor Author

ChuJiani commented Mar 9, 2024 •
edited
Loading

Unit test added in pytests/test_container_to_args.py.

Also: Do I need to place this option into or behind net args?

@p12tic
Copy link
Collaborator

p12tic commented Mar 9, 2024

Also: Do I need to place this option into or behind net args

There's stuff like --dns ten lines below your change, so I think it doesn't matter for now.

The PR looks good. Could you rebase on top of main instead of merging? This whole PR can be a single commit.

p12tic
p12tic reviewed Mar 9, 2024
View reviewed changes
podman_compose.py Outdated Show resolved Hide resolved
@ChuJiani
Copy link
Contributor Author

ChuJiani commented Mar 9, 2024

Sure! I will figure it out.

@ChuJiani
Copy link
Contributor Author

ChuJiani commented Mar 9, 2024 •
edited
Loading

It should work fine now.

@p12tic p12tic merged commit 43059dc into containers:main Mar 9, 2024
4 checks passed
@p12tic
Copy link
Collaborator

p12tic commented Mar 9, 2024

Thanks, looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p12tic p12tic p12tic requested changes

@JAORMX JAORMX JAORMX approved these changes

@NerdToMars NerdToMars NerdToMars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChuJiani @p12tic @JAORMX @NerdToMars