Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Node.js RAG recipe to default recipes #2384

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mhdawson
Copy link
Contributor

What does this PR do?

Adds the Node.js RAG recipe to the default recipes in the catalog

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

Need for more Node.js/JavaScript coverage in the recipes

How to test this PR?

  • Start podman desktop pointing to a copy of the podman-desktop-extension-ai-lab with this PR (pnpm watch --extension-folder ../podman-desktop-extension-ai-lab/packages/backend from clone of podman-desktop project is the way I do it)
  • Navigate to the Recipe Catalog under AI Lab (Might have to install AI Lab if it is not already)
  • Select the Node.js RAG chatbot recipe
  • Follow the standard steps to start the recipe
  • Validate that you can get to the main page and chat/adding documents works as you would expect from the main page.

@mhdawson mhdawson requested review from benoitf, jeffmaury and a team as code owners January 14, 2025 20:26
@feloy
Copy link
Contributor

feloy commented Jan 15, 2025

Could you please add values for languages and frameworks properties which have been added recently, and which will help the user filter the catalog (you can get examples of values in the PR #2354

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we added Granite 3.1 as the default model for several recipes, can you do it here and add the fields as @feloy mentioned

Thanks

@mhdawson
Copy link
Contributor Author

Looking at adding the fields

@mhdawson mhdawson force-pushed the add-nodejs-rag-recipe branch from 0f26c0e to e00448d Compare January 17, 2025 15:20
@mhdawson
Copy link
Contributor Author

@jeffmaury , requested changes made and rebased and tested.

@mhdawson mhdawson force-pushed the add-nodejs-rag-recipe branch from e00448d to 37f7ccb Compare January 17, 2025 20:17
@mhdawson
Copy link
Contributor Author

@feloy to confirm, I included the updates you requested.

@mhdawson mhdawson force-pushed the add-nodejs-rag-recipe branch from 37f7ccb to ff029f6 Compare January 21, 2025 15:18
@mhdawson
Copy link
Contributor Author

@jeffmaury is there anything else needed before this can land?

@mhdawson mhdawson force-pushed the add-nodejs-rag-recipe branch from ff029f6 to 094b647 Compare January 22, 2025 15:53
@jeffmaury
Copy link
Contributor

Me testing when back from pto

@mhdawson
Copy link
Contributor Author

@jeffmaury thanks for the info, sorry for bugging you on your PTO, enjoy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants