Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: avoid usage of null in codebase #3289

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Jul 20, 2023

What does this PR do?

avoid usage of null in codebase.
use undefined instead

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A

How to test this PR?

PR check should be green

@benoitf benoitf requested review from a team, slemeur and themr0c as code owners July 20, 2023 11:25
@benoitf benoitf requested review from jeffmaury and lstocchi and removed request for a team July 20, 2023 11:25
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/renderer/src/lib/dialogs/QuickPickInput.svelte Outdated Show resolved Hide resolved
use undefined instead
Signed-off-by: Florent Benoit <[email protected]>
@benoitf benoitf enabled auto-merge (rebase) July 20, 2023 12:36
@benoitf benoitf merged commit c70ec45 into containers:main Jul 20, 2023
10 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.3.0 milestone Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants