Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update website to handle the arm64 binaries for Windows #3652

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Aug 23, 2023

What does this PR do?

update website to handle the arm64 binaries for Windows

Screenshot/screencast of this PR

Before:
image

After:
image

What issues does this PR fix or reference?

fixes #3443

How to test this PR?

replace in website/src/pages/downloads/windows.tsx

-  const result = await fetch('https://api.github.com/repos/containers/podman-desktop/releases/latest');
+  const result = await fetch('https://api.github.com/repos/containers/podman-desktop/releases/118401175');

note: only merge this PR once 1.4.x is released

@benoitf benoitf requested review from slemeur, themr0c and a team as code owners August 23, 2023 15:42
@benoitf benoitf requested review from dgolovin and lstocchi and removed request for a team August 23, 2023 15:42
@benoitf benoitf changed the title chore: update website to handle the arm64 binaries for Windows [do not merge] chore: update website to handle the arm64 binaries for Windows Aug 23, 2023
@benoitf benoitf requested a review from mairin August 23, 2023 16:00
@benoitf benoitf added this to the 1.4.0 milestone Aug 23, 2023
Copy link
Contributor

@deboer-tim deboer-tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, suggestions could come later

website/src/pages/downloads/windows.tsx Outdated Show resolved Hide resolved
website/src/pages/downloads/windows.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally and the views work / shows arm binaries correctly (after the suggested change).

@benoitf benoitf force-pushed the update-website-windows-arm64 branch 2 times, most recently from efbbef1 to 305f1f7 Compare September 13, 2023 09:00
@benoitf benoitf changed the title [do not merge] chore: update website to handle the arm64 binaries for Windows chore: update website to handle the arm64 binaries for Windows Sep 19, 2023
@benoitf benoitf enabled auto-merge (rebase) September 19, 2023 14:47
@benoitf benoitf enabled auto-merge (squash) September 19, 2023 14:47
@benoitf benoitf merged commit bd44e4f into containers:main Sep 19, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Arm build
4 participants