-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update website to handle the arm64 binaries for Windows #3652
Merged
benoitf
merged 2 commits into
containers:main
from
benoitf:update-website-windows-arm64
Sep 19, 2023
Merged
chore: update website to handle the arm64 binaries for Windows #3652
benoitf
merged 2 commits into
containers:main
from
benoitf:update-website-windows-arm64
Sep 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
dgolovin and
lstocchi
and removed request for
a team
August 23, 2023 15:42
benoitf
changed the title
chore: update website to handle the arm64 binaries for Windows
[do not merge] chore: update website to handle the arm64 binaries for Windows
Aug 23, 2023
lstocchi
reviewed
Sep 5, 2023
deboer-tim
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, suggestions could come later
cdrage
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested locally and the views work / shows arm binaries correctly (after the suggested change).
benoitf
force-pushed
the
update-website-windows-arm64
branch
2 times, most recently
from
September 13, 2023 09:00
efbbef1
to
305f1f7
Compare
lstocchi
approved these changes
Sep 13, 2023
benoitf
changed the title
[do not merge] chore: update website to handle the arm64 binaries for Windows
chore: update website to handle the arm64 binaries for Windows
Sep 19, 2023
fixes containers#3443 Signed-off-by: Florent Benoit <[email protected]>
Signed-off-by: Florent Benoit <[email protected]>
benoitf
force-pushed
the
update-website-windows-arm64
branch
from
September 19, 2023 14:47
305f1f7
to
b4db1dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
update website to handle the arm64 binaries for Windows
Screenshot/screencast of this PR
Before:
After:
What issues does this PR fix or reference?
fixes #3443
How to test this PR?
replace in
website/src/pages/downloads/windows.tsx
note: only merge this PR once 1.4.x is released