chore: set local URL in development mode #3685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in production mode, keep the podman-desktop.io link Signed-off-by: Florent Benoit <[email protected]>
benoitf
requested review from
dgolovin and
cdrage
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When trying the website in development mode locally, some links are generated using the public URL which is podman-desktop.io
So if you have some new links/images they might reference links that are still not yet available remotely
Here it'll resolve them locally so if it works locally, after the merge it will also work in production mode
an example is the
twitter:imagelinks for example that will use the docusaurus config URL object and if you want to check locally it won't work as the link being generated is using podman-desktop.ioScreenshot/screencast of this PR
What issues does this PR fix or reference?
https://github.com/containers/podman-desktop/pull/3614/files#r1306822710
How to test this PR?