docs: add mermaid diagrams #3705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrage
requested review from
slemeur,
themr0c,
benoitf and
a team
as code owners
cdrage
requested review from
dgolovin and
lstocchi
and removed request for
a team
|
As requested by @themr0c |
benoitf
reviewed
Aug 29, 2023
You're right. It was ignored by mistake! Added. |
benoitf
requested changes
Aug 29, 2023
There was a problem hiding this comment.
I think there is something wrong in the yarn.lock changes (like trim being updated, etc)
could you revert yarn.lock changes and then run yarn command in the root folder and not in the website folder
I think then we should have a better yarn.lock file (most added lines and no replacement lines)
benoitf
reviewed
Aug 29, 2023
### What does this PR do? Adds mermaid diagrams to be used within the website. ### Screenshot/screencast of this PR https://github.com/containers/podman-desktop/assets/6422176/d893c7c8-ae28-4e47-90f6-84547b44b944 <!-- Please include a screenshot or a screencast explaining what is doing this PR --> ### What issues does this PR fix or reference? Closes containers#3706 <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> N/A ### How to test this PR? Add: ``` ```mermaid graph TD; A-->B; A-->C; B-->D; C-->D; ``` ``` To an example markdown page. Signed-off-by: Charlie Drage <[email protected]>
|
Updated! Reran I did:
Trim is no longer being updated now. Good catch! |
benoitf
approved these changes
Aug 29, 2023
themr0c
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: add mermaid diagrams
What does this PR do?
Adds mermaid diagrams to be used within the website.
Screenshot/screencast of this PR
Screen.Recording.2023-08-29.at.10.01.49.AM.mov
What issues does this PR fix or reference?
Closes #3706
N/A
How to test this PR?
Add: