-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tests): add podman desktop update e2e test #8653
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odockal
requested review from
jeffmaury,
feloy and
SoniaSandler
and removed request for
a team
August 29, 2024 13:12
odockal
force-pushed
the
issue-7931
branch
10 times, most recently
from
September 3, 2024 08:56
c473930
to
f2a4b91
Compare
odockal
force-pushed
the
issue-7931
branch
4 times, most recently
from
September 3, 2024 09:46
cfd05f9
to
8a1462a
Compare
@ScrewTSW In this pr there is the example of how to build and use the compiled binary with playwright. |
xbabalov
approved these changes
Sep 3, 2024
cbr7
reviewed
Sep 3, 2024
odockal
force-pushed
the
issue-7931
branch
2 times, most recently
from
September 9, 2024 10:29
309eaf9
to
676789a
Compare
ScrewTSW
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.github/workflows/pr-check.yaml
Outdated
exit 1 | ||
else | ||
echo "Windows updater test succeeded or was skipped..." | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing new line
Signed-off-by: Ondrej Dockal <[email protected]>
Signed-off-by: Ondrej Dockal <[email protected]>
Signed-off-by: Ondrej Dockal <[email protected]>
… merge Signed-off-by: Ondrej Dockal <[email protected]>
Signed-off-by: Ondrej Dockal <[email protected]>
Signed-off-by: Ondrej Dockal <[email protected]>
…n area/update label is added Signed-off-by: Ondrej Dockal <[email protected]>
Signed-off-by: Ondrej Dockal <[email protected]>
Signed-off-by: Ondrej Dockal <[email protected]>
Signed-off-by: Ondrej Dockal <[email protected]>
Signed-off-by: Ondrej Dockal <[email protected]>
Signed-off-by: Ondrej Dockal <[email protected]>
Signed-off-by: Ondrej Dockal <[email protected]>
Signed-off-by: Ondrej Dockal <[email protected]>
benoitf
approved these changes
Sep 9, 2024
benoitf
reviewed
Sep 9, 2024
benoitf
reviewed
Sep 9, 2024
Signed-off-by: Ondrej Dockal <[email protected]>
Signed-off-by: Ondrej Dockal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Brings new E2E update test. The test is intended to be run solely in the specific test environment. Windows (now) and Mac will be target env.
The update e2e test will run after each merge, and in the PR check if it was initialized by dependabot where we saw the most problems.
Screenshot / video of UI
What issues does this PR fix or reference?
#7931
How to test this PR?
On windows only now. See the details in the linked issue. You need change version of PD in package.json to something like
1.0.0
and then runyarn test:e2e:update
. Also, if you want to perform actual update during the testing, add env. var:UPDATE_PODMAN_DESKTOP=true
In order to be able to run the update in locally built podman desktop, you need to set
ELECTRON_ENABLE_INSPECT
env. var. and build the bits to have correct artifacts:pnpm compile:current --win nsis
. It will produce executable podman desktop binary, which will offer an update option. In order to execute the e2e tests now with built executable, usePODMAN_DESKTOP_BINARY="C:\path\to\dist\win-unpacked\Podman Desktop.exe"
when running test target.