Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): add podman desktop update e2e test #8653

Merged
merged 16 commits into from
Sep 9, 2024

Conversation

odockal
Copy link
Contributor

@odockal odockal commented Aug 29, 2024

What does this PR do?

Brings new E2E update test. The test is intended to be run solely in the specific test environment. Windows (now) and Mac will be target env.

The update e2e test will run after each merge, and in the PR check if it was initialized by dependabot where we saw the most problems.

Screenshot / video of UI

What issues does this PR fix or reference?

#7931

How to test this PR?

On windows only now. See the details in the linked issue. You need change version of PD in package.json to something like 1.0.0 and then run yarn test:e2e:update. Also, if you want to perform actual update during the testing, add env. var: UPDATE_PODMAN_DESKTOP=true
In order to be able to run the update in locally built podman desktop, you need to set ELECTRON_ENABLE_INSPECT env. var. and build the bits to have correct artifacts: pnpm compile:current --win nsis. It will produce executable podman desktop binary, which will offer an update option. In order to execute the e2e tests now with built executable, use PODMAN_DESKTOP_BINARY="C:\path\to\dist\win-unpacked\Podman Desktop.exe" when running test target.

  • Tests are covering the bug fix or the new feature

@odockal odockal requested review from benoitf and a team as code owners August 29, 2024 13:12
@odockal odockal requested review from jeffmaury, feloy and SoniaSandler and removed request for a team August 29, 2024 13:12
@odockal odockal marked this pull request as draft August 29, 2024 13:12
@odockal odockal force-pushed the issue-7931 branch 10 times, most recently from c473930 to f2a4b91 Compare September 3, 2024 08:56
@odockal odockal marked this pull request as ready for review September 3, 2024 09:40
@odockal odockal requested a review from cbr7 September 3, 2024 09:40
@odockal odockal force-pushed the issue-7931 branch 4 times, most recently from cfd05f9 to 8a1462a Compare September 3, 2024 09:46
@odockal
Copy link
Contributor Author

odockal commented Sep 3, 2024

@ScrewTSW In this pr there is the example of how to build and use the compiled binary with playwright.

@odockal odockal force-pushed the issue-7931 branch 2 times, most recently from 309eaf9 to 676789a Compare September 9, 2024 10:29
Copy link
Member

@ScrewTSW ScrewTSW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

exit 1
else
echo "Windows updater test succeeded or was skipped..."
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line

…n area/update label is added

Signed-off-by: Ondrej Dockal <[email protected]>
Signed-off-by: Ondrej Dockal <[email protected]>
@odockal odockal merged commit 4e583e9 into containers:main Sep 9, 2024
16 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.13.0 milestone Sep 9, 2024
@odockal odockal linked an issue Sep 9, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the E2E update path of the Podman Desktop
6 participants