-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test): test framework refactoring #9181
Conversation
Signed-off-by: Vladimir Lazar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with @benoitf
Signed-off-by: Vladimir Lazar <[email protected]>
…start Signed-off-by: Vladimir Lazar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was not convinced initially by remarks about extra await but found the rule quite logical: do not await the last expression of an async method
Signed-off-by: Vladimir Lazar <[email protected]>
@benoitf @jeffmaury As requested I've removed the final awaits in async methods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
What does this PR do?
Some fixes for e2e tests and some code refactoring to use test.step functionality.
What issues does this PR fix or reference?
#9170