Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): test framework refactoring #9181

Merged
merged 6 commits into from
Oct 3, 2024
Merged

Conversation

cbr7
Copy link
Contributor

@cbr7 cbr7 commented Oct 3, 2024

What does this PR do?

Some fixes for e2e tests and some code refactoring to use test.step functionality.

What issues does this PR fix or reference?

#9170

@cbr7 cbr7 linked an issue Oct 3, 2024 that may be closed by this pull request
@cbr7 cbr7 marked this pull request as ready for review October 3, 2024 07:25
@cbr7 cbr7 requested review from benoitf and a team as code owners October 3, 2024 07:25
@cbr7 cbr7 requested review from jeffmaury, feloy and deboer-tim and removed request for a team October 3, 2024 07:25
tests/playwright/src/model/pages/settings-bar.ts Outdated Show resolved Hide resolved
tests/playwright/src/model/pages/settings-bar.ts Outdated Show resolved Hide resolved
tests/playwright/src/model/pages/volumes-page.ts Outdated Show resolved Hide resolved
tests/playwright/src/model/pages/volumes-page.ts Outdated Show resolved Hide resolved
tests/playwright/src/model/pages/volumes-page.ts Outdated Show resolved Hide resolved
tests/playwright/src/model/pages/volumes-page.ts Outdated Show resolved Hide resolved
tests/playwright/src/model/pages/volumes-page.ts Outdated Show resolved Hide resolved
tests/playwright/src/model/pages/volumes-page.ts Outdated Show resolved Hide resolved
Copy link
Member

@ScrewTSW ScrewTSW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @benoitf

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was not convinced initially by remarks about extra await but found the rule quite logical: do not await the last expression of an async method

@cbr7
Copy link
Contributor Author

cbr7 commented Oct 3, 2024

@benoitf @jeffmaury As requested I've removed the final awaits in async methods

@cbr7
Copy link
Contributor Author

cbr7 commented Oct 3, 2024

Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@cbr7 cbr7 merged commit ca4d44c into main Oct 3, 2024
15 checks passed
@cbr7 cbr7 deleted the bug_fixes_and_refactoring branch October 3, 2024 19:44
@podman-desktop-bot podman-desktop-bot added this to the 1.13.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several e2e tests are failing in cicd and need to be fixed
6 participants