chore: add release notes to dashboard page - renderer #9190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Signed-off-by: Sonia Sandler <[email protected]>
Signed-off-by: Sonia Sandler <[email protected]>
Signed-off-by: Sonia Sandler <[email protected]>
SoniaSandler
force-pushed
the
release-notes-frontend
branch
from
f2e9d93
to
f4aebf5
Compare
SoniaSandler
requested review from
cdrage,
axel7083 and
gastoner
and removed request for
a team
deboer-tim
approved these changes
Oct 3, 2024
| } | ||
| async function getInfoFromNotes() { | ||
| let getNotes = await window.podmanDesktopGetReleaseNotes(); | ||
| notesAvailable = getNotes.releaseNotesAvailable; |
There was a problem hiding this comment.
This makes it seem like the getNotes.releaseNotesAvailable is fairly redundant, you can just use (getNotes.notes != undefined). Not critical now but maybe we can remove it later.
There was a problem hiding this comment.
I'll change it here and open a separate PR for the main part of it
benoitf
reviewed
Oct 3, 2024
Signed-off-by: Sonia Sandler <[email protected]>
Signed-off-by: Sonia Sandler <[email protected]>
Signed-off-by: Sonia Sandler <[email protected]>
Signed-off-by: Sonia Sandler <[email protected]>
benoitf
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sonia Sandler [email protected]
What does this PR do?
As part of the dashboard revamp, this PR adds the release notes to the dashboard page. This PR follows #8753, and uses the changes that have been made in the backend side to show the release notes on the dashboard page
updatebutton shows up when an update is availablelearn morebutton sends the user to the full release notes onpodman-desktop.io(or GitHub ifpodman-desktop.iois unavilable )Screenshot / video of UI
If update is unavailable:
Notes are unavailable, but GitHub summary is available:
Notes are unavailable also on GitHub:
What issues does this PR fix or reference?
Related to #8521
How to test this PR?
Open the dashboard page and check if the release notes are visible