chore: add methods to read or set docker contexts #9197
Merged
+506
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
dgolovin,
jeffmaury and
SoniaSandler
and removed request for
a team
benoitf
force-pushed
the
DESKTOP-9025-c
branch
from
0388bb9
to
3ad5f16
Compare
2 tasks
deboer-tim
approved these changes
Oct 3, 2024
| }); | ||
|
|
||
| contextBridge.exposeInMainWorld('switchDockerContext', async (contextName: string): Promise<DockerContextInfo[]> => { | ||
| return ipcInvoke('docker-compatibility:switchDockerContext', contextName); |
There was a problem hiding this comment.
Minor: I think I'd prefer setDockerContext. I know there are typically going to be 2, but switch sounds like toggling between two states, where set sounds like picking from the list.
There was a problem hiding this comment.
there is always the default state, there is never an unknown state
related to containers#9026 Signed-off-by: Florent Benoit <[email protected]>
benoitf
force-pushed
the
DESKTOP-9025-c
branch
from
3ad5f16
to
8d17098
Compare
jeffmaury
reviewed
Oct 4, 2024
To not have a direct dependency on the docker CLI from the Podman Desktop core. |
axel7083
reviewed
Oct 4, 2024
Signed-off-by: Florent Benoit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add methods to list and set the docker contexts
there is always a default context even when there is no files (like .docker/config.json or any .docker/context/** files) on the filesystem, it's what we're calling the system socket path.
unit tests provided
Screenshot / video of UI
What issues does this PR fix or reference?
related to #9026
How to test this PR?