[skip-ci] GHA: Fix intermittent workflow error

[cevich]

Periodically, the discussion-lock workflow throws the error: Resource not accessible by integration

This was identified in the upstream issue 47, as caused by a version-5 change that adds support for management of discussions but requires additional permissions and possibly settings. Given the low notification traffic from discussions, old discussions may remain valid for a long while, and are a useful community-interface: Disable management of discussions.

Does this PR introduce a user-facing change?

None

[cevich]

@edsantiago @lsm5 @mheon PTAL, this should fix the alerts we've been getting from this repo. There's no practical way to test this PR, so it needs to be manually merged (the bot will not work). If acceptable, I intend to open similar PRs for Buildah and Skopeo where we also receive this alert.

[cevich]

Clarification: "The fix worked for other people" is all I have to go on for this change.

[Luap99]

Let's please disable the thing for discussions instead, they are discussions and not meant locked just because someone closed them IMO.
dessant/lock-threads#47 (comment)

And if we do want to lock them I guess we must configure it the same way we did for PRs/issues so that it does not use the defaults.

[cevich]

Thanks for your input Paul, sorry I probably should have tagged you as well.

IIRC, the original concern was over receiving e-mail notifications relating to old closed PRs/Issues. So these would not be open/active discussions.

The workflow is already configured to use the same settings as for issues/PRs (and now discussions).

[Luap99]

IIRC, the original concern was over receiving e-mail notifications relating to old closed PRs/Issues. So these would not be open/active discussions.

Yes exactly which is why this change is wrong because you enable locking of discussions, IMO discussions are from and for community and we see plenty of non maintainers active there as well, there is no requirement for us to interact with them.
Discussions are also sorted by on activity so if someone is active on a old discussion then it will be back at the font and be discoverable for others to join in.

The workflow is already configured to use the same settings as for issues/PRs (and now discussions).

issue-inactive-days: '${{env.CLOSED_DAYS}}'
pr-inactive-days: '${{env.CLOSED_DAYS}}'
add-issue-labels: '${{env.LOCKED_LABEL}}'
add-pr-labels: '${{env.LOCKED_LABEL}}'

How do you set these for discussion? You currently don't so this fix would make things worse as it uses the defaults (which we do not liked)

[cevich]

Force-pushed: Added config. for discussions.

Note: I'm open to disabling management of discussions, assuming that's what the team wants. I'll make a note to bring this up.

[cevich]

Force-push: Disabled discussion-management, renamed job to better reflect this.

@Luap99 @mheon PTAL, this should be ready to go now.

[Luap99]

LGTM although I think if you change the name there you want to change it in the other place as well.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cevich]

Force-push: Renamed job and workflow file.

[packit-as-a-service]

Cockpit tests failed for commit 7f0268a. @martinpitt, @jelly, @mvollmer please check.

[edsantiago]

LGTM. Looking forward to Thursday or Friday to see if this fixes the problem. Thank you!

[edsantiago]

/lgtm

[cevich]

Looking forward to Thursday or Friday to see if this fixes the problem. Thank you!

Note: Both buildah and skopeo re-use this workflow via GHA magic. So by merging this we should find the problem is fixed everywhere. Hopefully.

[cevich]

Oops, nope, spoke too soon. The file rename is going to cause both Skopeo and Buildah to fail.

[edsantiago]

Good idea for a followup: add a huge all-caps warning saying "THIS FILE IS USED BY SKOPEO AND BUILDAH etc etc"

[cevich]

That is a good idea.