[skip-ci] RPM: cleanup macro defs #24864
Conversation
openshift-ci
bot
added
release-note-none
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
A friendly reminder that this PR had no activity for 30 days. |
The default `gobuild` macro on CentOS Stream 9 now includes support for `BUILDTAGS`. CentOS Stream envs now also define `_user_tmpfilesdir` macro by default. Both these definitions are no longer needed here. `libtrust_openssl` buildtag is also set in spec wherever relevant. Signed-off-by: Lokesh Mandvekar <[email protected]>
lsm5
force-pushed
the
rpm-macro-cleanup
branch
from
e144b87 to
76d234a
Compare
|
/packit build |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@containers/podman-maintainers PTAL |
|
@jnovy PTAL |
|
For |
| %if %{defined rhel} | ||
| %define fips 1 | ||
| %endif |
There was a problem hiding this comment.
I am not sure if fips is a good condition name, fips can be enabled on fedora as well.
AFAICT the build tag is calling some special code only in the rhel go builds? At least it doe snot compile on fedora with that tag. So I guess just using rhel as condition seems best.
But overall it would likely be great to have some actual docs on what that tag does and why rhel needs it, I guess some specific crypto policy.
There was a problem hiding this comment.
The question here is if we need libtrust_openssl in Fedora and CentOS too - by default?
There was a problem hiding this comment.
Well it doesn't build on fedora so the answer is we cannot use it on fedora.
And I guess the rhel macro also applies to centos by default?
There was a problem hiding this comment.
Yes, centos and rhel macros are defined in CentOS, in RHEL only rhel
The default
gobuildmacro on CentOS Stream 9 now includes support forBUILDTAGS.CentOS Stream envs now also define
_user_tmpfilesdirmacro by default.Both these definitions are no longer needed here.
Does this PR introduce a user-facing change?