Skip to content

Commit

Permalink
Merge branch '135-admin-user-invalid-login' into 'develop'
Browse files Browse the repository at this point in the history
Resolve "Admin user Invalid Login"

Closes #135

See merge request ch/user-manager!163
  • Loading branch information
MargoTuleninova committed Jun 7, 2018
2 parents 76ba57b + 89b36d4 commit f36f993
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions pkg/db/postgres/user.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,15 @@ func (pgdb *pgDB) GetAnyUserByLoginWOContext(login string) (*db.User, error) {
pgdb.log.Infoln("Get user by login", login)
var user db.User

rows, err := pgdb.conn.DB.Query("SELECT id FROM users WHERE login = $1", login)
rows, err := pgdb.conn.DB.Query("SELECT id, salt FROM users WHERE login = $1", login)
if err != nil {
return nil, err
}
defer rows.Close()
if !rows.Next() {
return nil, rows.Err()
}
err = rows.Scan(&user.ID)
err = rows.Scan(&user.ID, &user.Salt)
return &user, err
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/server/impl/admin.go
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ func (u *serverImpl) CreateFirstAdmin(password string) error {

if user != nil {
u.log.Info("updating admin password")
user.PasswordHash = utils.GetKey(user.Login, password, user.Salt)
user.PasswordHash = utils.GetKey("[email protected]", password, user.Salt)
err = u.svc.DB.UpdateUserWOContext(user)
if err != nil {
return err
Expand Down
1 change: 0 additions & 1 deletion pkg/server/impl/login.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ func (u *serverImpl) BasicLogin(ctx context.Context, request models.LoginRequest
u.log.Infoln("Basic login")
u.log.WithFields(logrus.Fields{
"username": request.Login,
"password": request.Password,
}).Debugln("Basic login details")

user, err := u.svc.DB.GetUserByLogin(ctx, request.Login)
Expand Down

0 comments on commit f36f993

Please sign in to comment.