Fixes 2474: Recover from tasks panics #446
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously if a task paniced for some reason, the worker routine would get 'stuck' and refuse to process anything else. Now the task is marked as failed and the worker can continue to pick up another task.
Testing steps
modify the pkg/taskss/introspection.go to panic sometimes or all the time:
Create some repository with with snapshotting turned off (for simplicity)
Now trigger introspection:
Run this a few times. eventually your workers will stop processing tasks. With this PR, they should always recover and mark the task as failed. You can check the tasks table' status column to confirm they are marked as failed.
Checklist