Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HMS-5287: Add playwright and github action to backend #956

Merged
merged 18 commits into from
Feb 5, 2025
Merged

HMS-5287: Add playwright and github action to backend #956

merged 18 commits into from
Feb 5, 2025
+1,426 −81

Conversation

Andrewgdewar
Copy link
Member

@Andrewgdewar Andrewgdewar commented Jan 28, 2025 •
edited
Loading

Summary

No code changes.

Added playwright

Added CICD pipeline for playwright integration.

Testing steps

@Andrewgdewar Andrewgdewar force-pushed the playwright-POC branch 2 times, most recently from 0c0f2da to e50365f Compare January 28, 2025 19:03
@Andrewgdewar Andrewgdewar mentioned this pull request Jan 28, 2025
Merged
@Andrewgdewar Andrewgdewar force-pushed the playwright-POC branch 3 times, most recently from 3ae3aed to a2c9128 Compare January 30, 2025 15:20
@Andrewgdewar Andrewgdewar changed the title Playwright poc HMS-5287: Add playwright and github action to backend Jan 30, 2025
@Andrewgdewar Andrewgdewar marked this pull request as ready for review January 30, 2025 15:21
@jlsherrill
Copy link
Member

https://issues.redhat.com/browse/HMS-5287

@Andrewgdewar Andrewgdewar force-pushed the playwright-POC branch 3 times, most recently from db995fc to 5d3c720 Compare January 31, 2025 17:06
@Andrewgdewar Andrewgdewar requested review from xbhouse, rverdile and jlsherrill and removed request for xbhouse and rverdile January 31, 2025 17:38
dominikvagner
dominikvagner previously requested changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@dominikvagner dominikvagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few small comments (+Matej's suggestions from the FE PR?) otherwise looks good and works! 🎉 nice to see the .nvmrc ✨
good job 👏🏼

(also personally I am not that well versed in GH workflows so maybe someone else could also have look) 😅

swadeley
swadeley reviewed Feb 3, 2025
View reviewed changes
swadeley
swadeley reviewed Feb 3, 2025
View reviewed changes
dominikvagner
dominikvagner reviewed Feb 4, 2025
View reviewed changes
Copy link
Contributor

@dominikvagner dominikvagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice updates, more/better docs are always appreciated 😌
but the .DS_Store files also need be removed from the commit along with ignoring them, so run this git rm --cached "*.DS_Store", commit, and will be good to go 😄

swadeley
swadeley reviewed Feb 4, 2025
View reviewed changes
xbhouse
xbhouse reviewed Feb 4, 2025
View reviewed changes
@jlsherrill
Copy link
Member

why use _playwright-tests instead of playwright-tests or ./tests/playwright/ ?

@Andrewgdewar
Copy link
Member Author

why use _playwright-tests instead of playwright-tests or ./tests/playwright/ ?

Just wanted to make it the same across front-end/back-end and had no outside input, I can adjust this should we want to move it.
I'd like to keep the node modules one layer deep for simplicity.

@Andrewgdewar Andrewgdewar merged commit cb90349 into main Feb 5, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swadeley swadeley

@xbhouse xbhouse

@dominikvagner dominikvagner

@jlsherrill jlsherrill

@rverdile rverdile

Assignees
No one assigned
Labels
qe-testing-needed Ready for QE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Andrewgdewar @jlsherrill @swadeley @xbhouse @dominikvagner