Skip to content

Commit

Permalink
Added teh Clear filter tab like the main page
Browse files Browse the repository at this point in the history
  • Loading branch information
kwarnerredhat committed Jan 19, 2024
1 parent 7f4b63d commit c431565
Showing 1 changed file with 15 additions and 24 deletions.
39 changes: 15 additions & 24 deletions src/Pages/PopularRepositoriesTable/PopularRepositoriesTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import {
TextInput,
InputGroupItem,
InputGroupText,
Chip,
} from '@patternfly/react-core';
import {
Table /* data-codemods */,
Expand Down Expand Up @@ -63,8 +62,8 @@ import {

const useStyles = createUseStyles({
clearFiltersChip: {
backgroundColor: '#007BFF',
color: '#FFFFFF',
backgroundColor: '#FFFFFF',
color: '#0096FF',
cursor: 'pointer',
padding: '8px',
borderRadius: '4px',
Expand Down Expand Up @@ -137,12 +136,6 @@ const PopularRepositoriesTable = () => {
const debouncedSearchValue = useDebounce(searchValue);
const [perPage, setPerPage] = useState(storedPerPage);
const [isActionOpen, setIsActionOpen] = useState(false);
const [filterData, setFilterData] = useState<FilterData>({
searchQuery: '',
versions: [],
arches: [],
statuses: [],
});

const onDropdownToggle = (_, isActionOpen: boolean) => {
setIsActionOpen(isActionOpen);
Expand Down Expand Up @@ -358,9 +351,9 @@ const PopularRepositoriesTable = () => {

const countIsZero = !data?.data?.length;

const clearFilters = () =>
setFilterData({ searchQuery: '', versions: [], arches: [], statuses: [] });
setSearchValue('');
function clearFilters(): void {
throw new Error('Function not implemented.');
}

return (
<Grid
Expand All @@ -385,6 +378,14 @@ const PopularRepositoriesTable = () => {
<SearchIcon />
</InputGroupText>
</InputGroupItem>
<Button
className={classes.clearFiltersChip}
onClick={clearFilters}
variant='link'
isInline
>
Clear filters
</Button>
<InputGroupItem>
<FlexItem className={classes.repositoryActions}>
{/* RBAC popover takes precedence */}
Expand Down Expand Up @@ -485,17 +486,7 @@ const PopularRepositoriesTable = () => {
isCompact
onPerPageSelect={onPerPageSelect}
/>
<Hide
hide={
!debouncedSearchValue &&
filterData.versions.length === 0 &&
filterData.arches.length === 0
}
>
<Chip onClick={clearFilters} className={classes.clearFiltersChip}>
Clear Filters
</Chip>
</Hide>
<Hide hide={!debouncedSearchValue}></Hide>
</Hide>
</FlexItem>
</Flex>
Expand Down Expand Up @@ -627,7 +618,7 @@ const PopularRepositoriesTable = () => {
</Hide>
<Hide hide={!countIsZero}>
<EmptyTableState
clearFilters={clearFilters}
clearFilters={() => setSearchValue('')}
notFiltered={!debouncedSearchValue} // The second item prevents the clear button from being removed abruptly
itemName='popular repositories'
/>
Expand Down

0 comments on commit c431565

Please sign in to comment.