Fixes 3336: expose module_hotfixes flag as checkbox for repo

[xbhouse]

Summary

Adds a switch to disable modularity filtering to the Add / Edit Repository modals. Default is to have modularity filtering enabled (module_hotfixes = false) and the switch set to off.

Testing steps

• Add a repository in the UI and toggle the modularity filtering switch to on (this should change the words to Modularity filtering disabled in the UI)
• Fetching this repository should show module_hotfixes = true
• Edit that repository in the UI and toggle the modularity filtering switch to off (this should change the words to Modularity filtering enabled in the UI)
• Fetching this repository should then show module_hotfixes = false

[jlsherrill]

https://issues.redhat.com/browse/HMS-3336

[Andrewgdewar]

Could you add an ouiId flag to this similar to what was done here for QE.

[xbhouse]

added!

[Andrewgdewar]

Ack pending above comment.

[swadeley]

/retest

[swadeley]

Hi

UI looks good

Here is the default state:

Here is with switch selected:

[swadeley]

Hi

With toggle switch not selected in UI, the default state, i.e. Modularity filtering disabled

print(app.content_sources.rest_client.repositories_api.get_repo_configuration_file('5dc0390a-8f39-4700-b597-fdd5141f0bcb','ff2bc409-ea95-465f-bb9d-f541bd870c7e'))
2024-01-17 09:19:27.206 [    INFO] [iqe.base.rest_client] REST: METHOD=GET, <snip>, params=[]
[gpgtest_snapshot_false]
name=gpgtest-snapshot-false
baseurl=https://env-ephemeral<snip>4e3b-9420-927da2b13905/
module_hotfixes=0
gpgcheck=1
repo_gpgcheck=0
enabled=1
gpgkey=https://ee-iyw94dk4.<snip>/api/content-sources/v1.0/repository_gpg_key/5dc0390a-8f39-4700-b597-fdd5141f0bcb

Now with Modularity filtering switch selected, "Modularity filtering disabled" shows in the UI, and a new snapshot (but no new publication):

In the repo it says:
'module_hotfixes': True,
In the repo config file for the snapshot it says:
module_hotfixes=1

print(app.content_sources.rest_client.repositories_api.get_repo_configuration_file('5dc0390a-8f39-4700-b597-fdd5141f0bcb','ff2bc409-ea95-465f-bb9d-f541bd870c7e'))
2024-01-17 09:31:44.653 [    INFO] [iqe.base.rest_client] REST: METHOD=GET, <snip>, params=[]
[gpgtest_snapshot_false]
name=gpgtest-snapshot-false
baseurl=https://env-ephemeral-<snip>/pulp/content/ba85dc81/5dc0390a-8f39-4700-b597-fdd5141f0bcb/d933ba2c-8d90-4e3b-9420-927da2b13905/
module_hotfixes=1
gpgcheck=1
repo_gpgcheck=0
enabled=1
gpgkey=https://ee-iyw94dk4.<snip>/api/content-sources/v1.0/repository_gpg_key/5dc0390a-8f39-4700-b597-fdd5141f0bcb

[xbhouse]

@jlsherrill @Andrewgdewar any advice here on how we can make this clearer for users? do you think sufficient documentation / reaching out to support will be enough or should I make any changes here to address the confusion?

[swadeley]

@jlsherrill @Andrewgdewar any advice here on how we can make this clearer for users? do you think sufficient documentation / reaching out to support will be enough or should I make any changes here to address the confusion?

Docs team will get to this, I think its OK for now.