-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HMS-5036: Update upload modal to allow cancellation #402
Conversation
ce7f6e3
to
3a9a103
Compare
4545f02
to
fb46ca1
Compare
@Andrewgdewar Please rebase |
src/Pages/Repositories/ContentListTable/components/SnapshotListModal/SnapshotListModal.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another small thing - i see the icons are clickable but show the tooltip on hover. should they be clickable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple small nitpicks and needs a rebase, but overall this looks and works great!! nice job 🎉
fb46ca1
to
0b125f2
Compare
0b125f2
to
11d7c24
Compare
This is likely from the patternfly component itself, and is likely due to accessibility requirements across platform (mobile) where there are no hover events. Hover is not a thing on touch devices, so anyone on a phone, tablet, or touch-notebook will be better off with the touch action causing the tooltip to appear. One thing I did change, was adding tabIndex={-1} to the file icons themselves, as I don't believe they need to be targetable via tabbing for screen readers, generally you want to only give tabbable elements actions, and the icons don't contain enough information for the screen reader to translate what we need here. |
ahh right, thanks for pointing that out! makes sense 👍 |
src/Pages/Repositories/ContentListTable/components/UploadContent/components/FileUploader.tsx
Outdated
Show resolved
Hide resolved
/retest |
Summary
Testing steps
Once the above are merged (or checked the backend pr 5126 is checked out)
Create an upload repository
Upload a larger file (here is a good example list)
While it is uploading, hit the cancel button. (can use network tab to turn on slow3g if necessary)
You can now either close the file, or retry the download (to have it pull the completed chunk list from the backend and restart)
Any combination of resuming/stopping/closing the modal/opening the modal/ reuploading SHOULD NOT result in any API error response. If one is seen during testing at any point, let me know.