Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list module Streams endpoint #14

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

Andrewgdewar
Copy link
Member

@Andrewgdewar Andrewgdewar commented Nov 14, 2024

This adds the "RpmRepositoryVersionModuleStreams" method.

That takes the following inputs

{
  "uuids": [
    "9d164ac6-b866-4808-af1f-847fbf588658",
    "36e449b9-3d61-43e8-a495-6ac332fdd3a8"
  ],
  "rpm_names": [],
  "search": ""
}

and returns a list of modules with their streams:

{
 data:[
  {
    "module_name": "swig",
    "streams": [
      {
        "Name": "swig",
        "Stream": "4.1",
        "Context": "rhel9",
        "Arch": "x86_64",
        "Version": "9020020221219141850",
        "Description": "Simplified Wrapper ... etc",
        "Profiles": {
          "common": [
            "swig"
          ],
          "complete": [
            "swig",
            "swig-doc",
            "swig-gdb"
          ]
        }
      }
    ]
  }
]
}

Additional changes

  • Added a mockery make command.

@Andrewgdewar Andrewgdewar marked this pull request as ready for review November 15, 2024 22:57
@rverdile rverdile self-assigned this Nov 20, 2024
Copy link
Collaborator

@rverdile rverdile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but looks really good overall. I tested it and everything seems to be working.

compose_files/pulp/docker-compose.yml Outdated Show resolved Hide resolved
pkg/tangy/rpm.go Outdated Show resolved Hide resolved
pkg/tangy/rpm.go Outdated Show resolved Hide resolved
.mockery.yaml Show resolved Hide resolved
.mockery.yaml Show resolved Hide resolved
@Andrewgdewar Andrewgdewar force-pushed the HMS-4932 branch 2 times, most recently from 59f5114 to 4820349 Compare November 29, 2024 00:18
@rverdile
Copy link
Collaborator

rverdile commented Dec 2, 2024

Changes look good, but since justin suggested to add some more fields to the response, I'll review again once that's done

Copy link
Collaborator

@rverdile rverdile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like pagination was removed, but I think we still want that, right?

@Andrewgdewar
Copy link
Member Author

it looks like pagination was removed, but I think we still want that, right?

No, unfortunately we decided we don't. There is a hard limit of 5000 items if that helps 😓

pkg/tangy/rpm.go Outdated Show resolved Hide resolved
pkg/tangy/rpm.go Outdated Show resolved Hide resolved
@Andrewgdewar Andrewgdewar force-pushed the HMS-4932 branch 3 times, most recently from 142cdfb to 9d20f40 Compare December 16, 2024 19:28
@Andrewgdewar Andrewgdewar force-pushed the HMS-4932 branch 4 times, most recently from 713737e to f6555ea Compare December 17, 2024 14:58
Copy link
Member

@jlsherrill jlsherrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack from me, @rverdile may want one final look?

Copy link
Collaborator

@rverdile rverdile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Andrewgdewar Andrewgdewar merged commit 6507fd1 into content-services:main Dec 19, 2024
2 checks passed
@jlsherrill jlsherrill changed the title Fixes 4932: Add list module Streams endpoint Add list module Streams endpoint Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants