-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list module Streams endpoint #14
Conversation
d8d8fe7
to
5b46580
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, but looks really good overall. I tested it and everything seems to be working.
59f5114
to
4820349
Compare
Changes look good, but since justin suggested to add some more fields to the response, I'll review again once that's done |
6e39b16
to
6035e28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like pagination was removed, but I think we still want that, right?
No, unfortunately we decided we don't. There is a hard limit of 5000 items if that helps 😓 |
142cdfb
to
9d20f40
Compare
713737e
to
f6555ea
Compare
f6555ea
to
c334c41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack from me, @rverdile may want one final look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This adds the "RpmRepositoryVersionModuleStreams" method.
That takes the following inputs
and returns a list of modules with their streams:
Additional changes