Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rpm list api #5

Merged
merged 7 commits into from
Mar 6, 2024
Merged

Add rpm list api #5

merged 7 commits into from
Mar 6, 2024

Conversation

jlsherrill
Copy link
Member

@jlsherrill jlsherrill commented Feb 26, 2024 •
edited
Loading

This adds a new function to list rpms in a repository version, also refactors existing functions to use query arguments.

@jlsherrill jlsherrill mentioned this pull request Feb 28, 2024
Merged
1 task
@jlsherrill jlsherrill marked this pull request as ready for review February 28, 2024 21:17
rverdile
rverdile reviewed Mar 5, 2024
View reviewed changes
pkg/tangy/rpm.go Outdated Show resolved Hide resolved
rverdile
rverdile reviewed Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@rverdile rverdile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add the list function to the examples the README?

@jlsherrill
Copy link
Member Author

I think i got all your feedback addressed.

rverdile
rverdile approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@rverdile rverdile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested all the methods.

@jlsherrill jlsherrill merged commit 358a433 into content-services:main Mar 6, 2024
2 checks passed
@jlsherrill jlsherrill deleted the rpm_list branch March 6, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rverdile rverdile rverdile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlsherrill @rverdile