Skip to content

Commit

Permalink
chore: Update commitlint configuration (#818)
Browse files Browse the repository at this point in the history
We no longer need to work around KeisukeYamashita/commitlint-rs#355.

Also: Add `cawg_identity` scope.
  • Loading branch information
scouten-adobe authored Jan 7, 2025
1 parent b12fffd commit c5289f0
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 49 deletions.
36 changes: 0 additions & 36 deletions .commitlintrc.no-scope.yml

This file was deleted.

10 changes: 3 additions & 7 deletions .commitlintrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,13 @@ rules:
# Scope must be one of the following
scope:
level: error
optional: true
options:
- c2patool
- cawg_identity
- export_schema
- make_test_images
- sdk
- c2patool

# Scope may be empty
# (NOTE: Disabled for now while we work around
# https://github.com/KeisukeYamashita/commitlint-rs/issues/355.)
# scope-empty:
# level: ignore

# Subject line should exist
subject-empty:
Expand Down
7 changes: 1 addition & 6 deletions .github/workflows/pr_title.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,6 @@ jobs:
echo --- commitlint results for PR title \"$PR_TITLE\" ---
echo  
# Workaround for https://github.com/KeisukeYamashita/commitlint-rs/issues/355
if echo "$PR_TITLE" | grep -E "^[a-z]+\(.*\): "; then
echo "$PR_TITLE" | commitlint -g .commitlintrc.yml
else
echo "$PR_TITLE" | commitlint -g .commitlintrc.no-scope.yml
fi
echo "$PR_TITLE" | commitlint -g .commitlintrc.yml
echo "✅ PR title matches all enforced rules."

0 comments on commit c5289f0

Please sign in to comment.