Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MINOR) Fragmented BMFF media #572

Merged
merged 8 commits into from
Aug 30, 2024
Merged

(MINOR) Fragmented BMFF media #572

merged 8 commits into from
Aug 30, 2024

Conversation

mauricefisher64
Copy link
Collaborator

Changes in this pull request

Add support for adding manifest to BMFF fragmented media (i.e. DASH). The caller is required to supply the init segment and the list of fragments. Note: This PR does not support fragmented content with existing manifests.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@mauricefisher64 mauricefisher64 requested review from scouten-adobe and gpeacock and removed request for scouten-adobe August 28, 2024 20:12
@mauricefisher64 mauricefisher64 changed the title Fragmented BMFF media (MINOR) Fragmented BMFF media Aug 28, 2024
Copy link
Collaborator

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Have you tried building this with make test? I'm guessing we may need some things behind the file_io feature.

@mauricefisher64 mauricefisher64 merged commit 72ca3ad into main Aug 30, 2024
22 checks passed
@mauricefisher64 mauricefisher64 deleted the fragment_support branch August 30, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants