Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update API documentation #621

Merged
merged 11 commits into from
Oct 23, 2024
Merged

doc: Update API documentation #621

merged 11 commits into from
Oct 23, 2024

Conversation

crandmck
Copy link
Collaborator

@crandmck crandmck commented Oct 8, 2024

Review doc comments for Reader.

Changes in this pull request

Edits to doc comments in Rust code for clarity and completeness.

TO DO:

  • Change all references to errors to be to the [Error] enum

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

More updates to doc comments from mtg w Gavin
More updates to doc comments from mtg w Gavin
@crandmck crandmck changed the title [WIP] ignore: Update API documentation docs: [WIP] Update API documentation Oct 17, 2024
@crandmck crandmck changed the title docs: [WIP] Update API documentation doc: [WIP] Update API documentation Oct 17, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 24.25%. Comparing base (5325170) to head (b3f0868).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sdk/src/ingredient.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #621   +/-   ##
=======================================
  Coverage   24.25%   24.25%           
=======================================
  Files          88       88           
  Lines       22100    22100           
=======================================
  Hits         5360     5360           
  Misses      16740    16740           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crandmck crandmck changed the title doc: [WIP] Update API documentation doc: Update API documentation. Oct 21, 2024
@crandmck crandmck changed the title doc: Update API documentation. doc: Update API documentation Oct 21, 2024
@crandmck crandmck requested a review from gpeacock October 23, 2024 00:04
Copy link
Collaborator

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested some changes but otherwise good to go.

@crandmck
Copy link
Collaborator Author

Addressed your comments.

@crandmck crandmck requested a review from gpeacock October 23, 2024 20:30
@crandmck crandmck merged commit cda279b into main Oct 23, 2024
23 of 24 checks passed
@crandmck crandmck deleted the rmckinne/api24-docs branch October 23, 2024 22:08
@scouten-adobe scouten-adobe mentioned this pull request Oct 23, 2024
@scouten-adobe scouten-adobe mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants