lando-dependency: Removed lando dependencies from setup #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussainweb
requested changes
Nov 7, 2023
There was a problem hiding this comment.
@gauravaxl, I see a DDEV related error in CI. Did you check the error? Does DDEV work locally for you?
Furthermore, the frontend_vr job still depends on files from Lando. I think we should get that running on DDEV first and then remove this.
Finally, you removed .gitpod.yml. Why?
|
yes, ddev is working fine for me, I just made one change into my local i.e - I have update the mariadb version: "10.6" from version: "10.11" as it was throwing error to me. I have restored and update the task from lando to ddev in .gitpod.yml file. I removed it by mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.