Fix scaling on autoscale enabled service

convox · Jul 3, 2024 · c173ed1 · c173ed1
1 parent 6c77500
commit c173ed1
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/provider/aws/releases.go b/provider/aws/releases.go
@@ -358,7 +358,7 @@ func (p *Provider) ReleasePromote(app, id string, opts structs.ReleasePromoteOpt
 		}
 
 		autoscale := false
-		if stackAutoscale == "Yes" && s.Scale.Count.Min < s.Scale.Count.Max {
+		if stackAutoscale == "Yes" {
 			autoscale = true
 		}
 

diff --git a/provider/aws/service.go b/provider/aws/service.go
@@ -260,5 +260,23 @@ func (p *Provider) ServiceUpdate(app, name string, opts structs.ServiceUpdateOpt
 		return err
 	}
 
+	if opts.Count != nil {
+		sarn, err := p.serviceArn(app, name)
+		if err != nil {
+			return err
+		}
+
+		if sarn != "" {
+			_, err := p.ecs().UpdateService(&ecs.UpdateServiceInput{
+				Cluster:      aws.String(p.Cluster),
+				Service:      aws.String(sarn),
+				DesiredCount: aws.Int64(int64(*opts.Count)),
+			})
+			if err != nil {
+				return err
+			}
+		}
+	}
+
 	return nil
 }