Compatibility with jupyter_core version 5+

[sizhky]

Specifically improves compatibility with jupyter environments that use ipykernels like jupyter-lab

#230

[cool-RR]

Looks good.

1. I think that the if after your code should be an elif.
2. Can you show a screenshot of before and after this change in the Jupyter shell?
3. Are you reasonable sure you're not breaking anything else?
4. If there happens to be a Windows version of /var/folders/, it'll be nice to include it too. Not a dealbreaker.
5. Change \d in the regular expression to [0-9].

[sizhky]

• I think that the if after your code should be an elif.
• Can you show a screenshot of before and after this change in the Jupyter shell?
• Are you reasonable sure you're not breaking anything else?
• If there happens to be a Windows version of /var/folders/, it'll be nice to include it too. Not a dealbreaker.
  I'm not in a position to test this.
• Change \d in the regular expression to [0-9].

[cool-RR]

Good job. All done and ready for merging?

[sizhky]

Yep!

[sizhky]

Anything still pending?

[cool-RR]

My grandma always told me to let PRs chill in the fridge overnight before merging, they taste better that way.

Merged and released. Would you care to install PySnooper 1.2.1 using pip (or any other package manager) and test whether it works fine?

[sizhky]

yeah it's working

[cool-RR]

Thank you. Good job.