Rename if_re_bsd.h and rtlhw.cpp to match BSD driver #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it easier to relate the BSD driver sources to the Windows driver sources, restore the original BSD driver filenames: - `rtlhw.cpp` -> `if_re.c` - `if_re_bsd.h` -> `if_rereg.h` Also, compile the BSD sources using C rules instead of C++ rules, which hopefully make it easier to keep the BSD and Windows code aligned. Compiling as C code requires a few fixes: - Functions shared between C and C++ code need to be compiled as `extern "C"`. - To use `bool` in C code, you have to include the `stdbool.h` header. - During the build, the compiler can't use the same .pch for both C and C++ code, so only "precompile" the header for the C++ code (compile the C code without precompiled header acceleration).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it easier to relate the BSD driver sources to the Windows driver sources, restore the original BSD driver filenames:
rtlhw.cpp->if_re.cif_re_bsd.h->if_rereg.hAlso, compile the BSD sources using C rules instead of C++ rules, which hopefully make it easier to keep the BSD and Windows code aligned.
Compiling as C code requires a few fixes:
extern "C".boolin C code, you have to include thestdbool.hheader.