add validation to avoid petitions between the same user and organization

coopdevs · Jan 3, 2025 · e9690bc · e9690bc
1 parent 0ecec0f
commit e9690bc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/app/controllers/petitions_controller.rb b/app/controllers/petitions_controller.rb
@@ -11,7 +11,7 @@ def create
 
       flash[:notice] = t('petitions.application_status', status: t("petitions.status.sent"))
     else
-      flash[:error] = t('errors.internal_server_error.description')
+      flash[:error] = petition.errors.full_messages.to_sentence
     end
 
     redirect_back fallback_location: organization_path(petition.organization)
@@ -25,7 +25,7 @@ def update
       petition.user.add_to_organization(petition.organization) if status == 'accepted'
       flash[:notice] = t('petitions.application_status', status: t("petitions.status.#{status}"))
     else
-      flash[:error] = t('errors.internal_server_error.description')
+      flash[:error] = petition.errors.full_messages.to_sentence
     end
 
     redirect_to manage_petitions_path

diff --git a/app/models/petition.rb b/app/models/petition.rb
@@ -3,4 +3,6 @@ class Petition < ApplicationRecord
 
   belongs_to :user
   belongs_to :organization
+
+  validates :user_id, uniqueness: { scope: :organization_id }
 end