[16.0] [REF] [MIG] coopiteasy_custom #106

victor-champonnois · 2023-07-26T13:41:41Z

Refactoring coopiteasy_custom :
- put two functionalities in their own modules : task_author_id and sort_project_by_timesheet_line_count
- linked_tasks functionality is now standard as "dependent tasks". Need to write a script to migrate linked_tasks to dependent tasks.
  - Note : I could also have used subtasks but the functional intention is different, subtasks tends to be in the same project by default (unless the subtask's project is already set). Subtasks are child tasks, while dependent tasks are tasks that must be done before the other task. Since we used linked_tasks mainly for mise en prod tasks, dependent tasks make more sense.
- other custom fields (reviewer,tester,priority) are abandoned because they are not used
- PR field is now in a OCA module
- not searching in closed project can be replaced by archiving project

cf internal discussion : https://docs.google.com/spreadsheets/d/1Bcyhw0BJRztjKtIGJmnnpBXLGv5Ctb7l378MqoyjgFQ/edit#gid=2001558567

And porting to 16.0

Note : I didn't make a PR to 12 because it is useless. This refactoring is only due to the migration because we want to reduce the codebase.

~~@carmenbianca I am not sure if I should write a script to rename the cron's XML IDs. Do you have an opinion ?~~ (not nessary anymore)

@robinkeunen I am really wondering whether it is worth it to continue using "sort_project_by_timesheet_line_count". Without this module, with Odoo standard, we can order the projects via total_timesheet_time or by task_count (just by configuring the DB via the interface). This module seems a bit complex to me compared to the functionality it provides.
If we don't want to use 'in interface' configuration because it could get lost in future migration, we could just set the model's order to total_timesheet_time or task_count in a module, without the need to compute "recent_timesheet_line_count".
What do you think ?

task : https://gestion.coopiteasy.be/web#id=10959&action=475&active_id=492&model=project.task&view_type=form&menu_id=

ne pas merger tant que les scripts linked_tasks et PR ne sont pas validés

codecov-commenter · 2023-07-26T13:46:01Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8a5913d) 87.80% compared to head (63cf94c) 88.37%.
Report is 1 commits behind head on 16.0.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             16.0     #106      +/-   ##
==========================================
+ Coverage   87.80%   88.37%   +0.56%     
==========================================
  Files           6        9       +3     
  Lines         123      129       +6     
  Branches       15       15              
==========================================
+ Hits          108      114       +6     
  Misses          9        9              
  Partials        6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

robinkeunen · 2023-07-31T10:24:17Z

@victor-champonnois Ok to not porting sort_project_by_timesheet_line_count and go by your suggestion. If that's not enough, I'll complain and code it on the 3rd of septembre 2025

victor-champonnois · 2023-08-01T14:56:42Z

@robinkeunen OK, I remove it then, thanks

victor-champonnois · 2023-08-01T14:57:37Z

TODO : test the script to migrate linked_tasks to dependent tasks

victor-champonnois · 2023-08-07T14:24:26Z

migration script needed for PR field

carmenbianca · 2023-09-05T08:54:07Z

Maybe a helpful comment, but I wonder how migration scripts will work in this scenario. I envision the following execution flow:

All installed modules are upgraded and run their migration scripts during the Odoo version migration.
coopiteasy_custom is an installed module, so it is upgraded.
As part of the upgrade, task_author_id is freshly installed.
coopiteasy_custom migration scripts are run.
task_author_id was freshly installed, so no migration scripts are run.

coopiteasy_custom/migrations/pre-migrate.py

robinkeunen · 2024-01-24T10:55:05Z

coopiteasy_custom/migrations/pre-migrate.py

+    for task in env["project.task"].search([]):
+        if task.link_task_ids:
+            task.project_id.allow_task_dependencies = True
+            task.write({"depend_on_ids": task.link_task_ids})


@remytms will this work ? The field is not defined anymore un the module at execution time.

robinkeunen · 2024-01-24T13:34:30Z

@huguesdk @remytms @victor-champonnois Can I get some review please 🙏

[ADD] cie_custom: uri and priority fields Signed-off-by: Carmen Bianca Bakker <[email protected]>

…time sheets Signed-off-by: Carmen Bianca Bakker <[email protected]>

Signed-off-by: Carmen Bianca Bakker <[email protected]>

blacken coopiteasy custom wip Signed-off-by: Carmen Bianca Bakker <[email protected]>

Signed-off-by: Carmen Bianca Bakker <[email protected]>

limit timesheet activity projects selection to open projects.

move analytic account custom order logic to project. previously (in odoo 9), timesheet lines where directly linked to analytic accounts. now (in odoo 12), they are linked to projects.

limit timesheet activity projects selection to open projects in task timesheets and timesheet sheet details.

Signed-off-by: Carmen Bianca Bakker <[email protected]>

allow to directly select a task (from open projects only) in a timesheet line without selecting a project first.

abandon other functionalities

carmenbianca

lgtm, one comment

carmenbianca · 2024-04-02T07:38:46Z

coopiteasy_custom/migrations/post-migrate.py

+@openupgrade.migrate()
+def migrate(env, version):
+    env.cr.execute(
+        """
+    alter table project_task drop column if exists reviewer_id;
+    alter table project_task drop column if exists tester_id;
+    alter table project_task drop column if exists int_priority;
+    drop table link_task_relation_table;
+    """
+    )
+    env.cr.commit()


this is typically not done in oca projects, preferring to keep (dead) data. here we may not care because we're the only user?

yes, i think we can clean it up : these fields were very sparsely used, the data in it is not relevant.

github-grap-bot · 2024-04-02T13:19:41Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

victor-champonnois requested review from huguesdk, robinkeunen, carmenbianca and remytms July 26, 2023 13:41

victor-champonnois force-pushed the 16.0-mig-coopiteasy_custom branch from b3f2246 to 835732a Compare July 26, 2023 13:41

victor-champonnois changed the title ~~16.0 [MIG] coopiteasy_custom~~ [16.0] [REF] [MIG] coopiteasy_custom Jul 26, 2023

github-grap-bot added the needs review label Jul 26, 2023

victor-champonnois force-pushed the 16.0-mig-coopiteasy_custom branch 3 times, most recently from 1e9a96e to 75d3f12 Compare July 27, 2023 09:59

victor-champonnois force-pushed the 16.0-mig-coopiteasy_custom branch from adaeab3 to 60d654e Compare August 1, 2023 14:55

robinkeunen requested changes Jan 24, 2024

View reviewed changes

robinkeunen force-pushed the 16.0-mig-coopiteasy_custom branch from 60d654e to f6207d3 Compare January 24, 2024 13:33

robinkeunen self-requested a review January 24, 2024 13:34

robinkeunen force-pushed the 16.0-mig-coopiteasy_custom branch from f6207d3 to 35fee29 Compare January 24, 2024 13:35

robinkeunen added 8 commits February 1, 2024 17:24

[ADD] cie_custom: uri and priority fields

c9874f2

[ADD] cie_custom: uri and priority fields Signed-off-by: Carmen Bianca Bakker <[email protected]>

[ADD] cie_custom: cron to fix qty_delivered on sale_orders linked to …

d3829e1

…time sheets Signed-off-by: Carmen Bianca Bakker <[email protected]>

[ADD] cie_custom: priority on kanban and tree views

c7095da

Signed-off-by: Carmen Bianca Bakker <[email protected]>

[ADD] cie_custom: fields on tasks

03a10d7

blacken coopiteasy custom wip Signed-off-by: Carmen Bianca Bakker <[email protected]>

[IMP] coopaname_custom: description

15ad9b3

Signed-off-by: Carmen Bianca Bakker <[email protected]>

[IMP] cie_custom: only display active account in activity_view

2837177

Signed-off-by: Carmen Bianca Bakker <[email protected]>

[IMP] cie_custom: order account by frequency

85a538d

Signed-off-by: Carmen Bianca Bakker <[email protected]>

[ADD] cie_custom: cron to compute aaa line count

2b16b83

Signed-off-by: Carmen Bianca Bakker <[email protected]>

carmenbianca and others added 24 commits February 1, 2024 17:24

[REM] coopiteasy_custom: Remove cie_fix_account_analytic_line_so_line

21c8db2

Signed-off-by: Carmen Bianca Bakker <[email protected]>

[FIX] coopiteasy_custom: Run pre-commit

7d6cd38

Signed-off-by: Carmen Bianca Bakker <[email protected]>

[UPD] Update coopiteasy_custom.pot

4394116

Regenerate all README.rst

017344a

Signed-off-by: Carmen Bianca Bakker <[email protected]>

[IMP] limit timesheet activity projects selection

ddb2f12

limit timesheet activity projects selection to open projects.

[FIX] order projects by recent timesheet lines

080f184

move analytic account custom order logic to project. previously (in odoo 9), timesheet lines where directly linked to analytic accounts. now (in odoo 12), they are linked to projects.

[FIX] limit timesheet projects in more views

475637d

limit timesheet activity projects selection to open projects in task timesheets and timesheet sheet details.

[UPD] Update coopiteasy_custom.pot

94fe52d

coopiteasy_custom 12.0.1.1.0

5563d1d

[ADD] coopiteasy_custom: Do not make closed projects selectable in tasks

f3f20cc

Signed-off-by: Carmen Bianca Bakker <[email protected]>

coopiteasy_custom 12.0.1.2.0

7a19b96

[FIX] SCRLfs → SC

4bfce6e

Signed-off-by: Carmen Bianca Bakker <[email protected]>

[IMP] search through all tasks in timesheet lines

f07a9a8

allow to directly select a task (from open projects only) in a timesheet line without selecting a project first.

[UPD] Update coopiteasy_custom.pot

59c4591

[UPD] README.rst

18778aa

coopiteasy_custom 12.0.1.3.0

00947ee

[IMP] coopiteasy_custom: black, isort, prettier

f70b45b

[REF] split coopiteasy_custom -> task_author_id

e89b126

abandon other functionalities

[FIX] task view overide

305844b

[MIG] coopiteasy_custom: Migration to 13.0

592f268

[MIG] coopiteasy_custom: Migration to 14.0

0fc8a2f

[MIG] coopiteasy_custom: Migration to 15.0

c8310b8

[MIG] coopiteasy_custom: Migration to 16.0

9728c71

fixup! [MIG] coopiteasy_custom: Migration to 16.0

63cf94c

robinkeunen force-pushed the 16.0-mig-coopiteasy_custom branch from 35fee29 to 63cf94c Compare February 1, 2024 16:24

robinkeunen approved these changes Feb 2, 2024

View reviewed changes

carmenbianca approved these changes Apr 2, 2024

View reviewed changes

github-grap-bot added approved ready to merge labels Apr 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0] [REF] [MIG] coopiteasy_custom #106

[16.0] [REF] [MIG] coopiteasy_custom #106

victor-champonnois commented Jul 26, 2023 •

edited

Loading

codecov-commenter commented Jul 26, 2023 •

edited

Loading

robinkeunen commented Jul 31, 2023

victor-champonnois commented Aug 1, 2023

victor-champonnois commented Aug 1, 2023

victor-champonnois commented Aug 7, 2023

carmenbianca commented Sep 5, 2023

robinkeunen Jan 24, 2024

robinkeunen commented Jan 24, 2024

carmenbianca left a comment

carmenbianca Apr 2, 2024

robinkeunen Apr 2, 2024

github-grap-bot commented Apr 2, 2024

[16.0] [REF] [MIG] coopiteasy_custom #106

Are you sure you want to change the base?

[16.0] [REF] [MIG] coopiteasy_custom #106

Conversation

victor-champonnois commented Jul 26, 2023 • edited Loading

codecov-commenter commented Jul 26, 2023 • edited Loading

Codecov Report

robinkeunen commented Jul 31, 2023

victor-champonnois commented Aug 1, 2023

victor-champonnois commented Aug 1, 2023

victor-champonnois commented Aug 7, 2023

carmenbianca commented Sep 5, 2023

robinkeunen Jan 24, 2024

Choose a reason for hiding this comment

robinkeunen commented Jan 24, 2024

carmenbianca left a comment

Choose a reason for hiding this comment

carmenbianca Apr 2, 2024

Choose a reason for hiding this comment

robinkeunen Apr 2, 2024

Choose a reason for hiding this comment

github-grap-bot commented Apr 2, 2024

victor-champonnois commented Jul 26, 2023 •

edited

Loading

codecov-commenter commented Jul 26, 2023 •

edited

Loading