Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] rotordc_autofill_product_variant: migration to 16.0 #117

Open
wants to merge 15 commits into
base: 16.0
Choose a base branch
from

Conversation

huguesdk
Copy link
Member

@huguesdk huguesdk commented Nov 1, 2024

odoo task

t12917

Copy link
Member

@polchampion polchampion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionaly tested on rotor-v16-test, partial success:

  • weight
  • volume and dimensions
  • internal reference [EDIT : it works]

test report: the internal reference is only copied for the firest variant created. In v16, there is a non-blocking warning when adding an internal reference that is already used. Maybe that's the reason why the internal reference doesn't get copied to variants beyond the first one.

@polchampion
Copy link
Member

functionaly tested on rotor-v16-test, partial success:

* [x]  weight

* [x]  volume and dimensions

* [ ]  **internal reference** [EDIT : it works]

test report: the internal reference is only copied for the firest variant created. In v16, there is a non-blocking warning when adding an internal reference that is already used. Maybe that's the reason why the internal reference doesn't get copied to variants beyond the first one.

@huguesdk I actually had tested without installing the module. Weight and dimensions are copied anyway, so idk if this part of the code is relevant. Internal reference is copied correctly.

Copy link
Member

@polchampion polchampion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

successful functional test

use the same method to copy variant values as in product_dimension.
@huguesdk
Copy link
Member Author

@polchampion thanks to you i discovered a bug in product_dimension (OCA/product-attribute#1811) and simplified the code of this module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants