Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy README.md to gh-pages branch as website #35

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Conversation

palmskog
Copy link
Member

This is to partially address #31. For every push to the main branch, README.md is deployed as index.md to the branch gh-pages, where it will be processed by Jekyll into HTML. To make the deployed HTML usable, the links need to be absolute (since we don't want to deploy .v files), so I edit README.md to do this.

Copy link
Member

@tchajed tchajed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rewrite the URLs only in the jekyll build? I think doing a replacement for \(src/.*\.v\) is safe enough. Making the LICENSE links absolute seems fine to me.

Currently this would create dead links for new files in PRs and would make other branches always link to main.

@palmskog palmskog requested a review from tchajed July 25, 2024 17:10
@palmskog
Copy link
Member Author

@tchajed so can I merge this now?

Copy link
Member

@tchajed tchajed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tchajed tchajed merged commit a4b22ce into main Jul 26, 2024
3 checks passed
@tchajed tchajed deleted the deploy-readme branch July 26, 2024 15:00
@palmskog
Copy link
Member Author

Looks pretty good, maybe we can add a link in the repo description? https://coq-community.org/coq-tricks/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants