Enriched and unified syntax for reduction strategies #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkySkimmer
reviewed
Apr 30, 2024
| red_expr ::= red_name pattern_opt flags_opt | ||
| red_name ::= "cbv" | "cbn" | "lazy" | "simpl" | ||
| pattern ::= CONSTR | ||
| flags ::= "with" head_flag_opt flag_list unfold_bases |
There was a problem hiding this comment.
why is head_flag separate? Is there something wrong with writing eg with beta head?
There was a problem hiding this comment.
I don't remember if there was a technical reason or just because I was thinking at head as a modifier of a different nature than the flags.
SkySkimmer
reviewed
Apr 30, 2024
text/unified-reduction-strategies.md
Outdated
| flag ::= "beta" | "iota" | "zeta" | "match" | "fix" | "cofix" | "delta" | ||
| unfold_bases ::= "+" unfold_base signed_unfold_base_list | signed_unfold_base_list | ||
| signed_unfold_base ::= unfold_base | "-" unfold_base | ||
| unfold_base ::= "[" QUALID_list "]" | IDENT constraint_opt | module "(" QUALID ")" |
There was a problem hiding this comment.
is this supposed to be
Suggested change
| unfold_base ::= "[" QUALID_list "]" | IDENT constraint_opt | module "(" QUALID ")" | |
| unfold_base ::= "[" QUALID_list "]" | IDENT constraint_opt | "module" "(" QUALID ")" |
?
SkySkimmer
reviewed
Apr 30, 2024
text/match-with-alias.md
Outdated
There was a problem hiding this comment.
Sorry, the usual bad habit of starting a new branch on top of the previous one.
Co-authored-by: Gaëtan Gilbert <[email protected]>
herbelin
force-pushed
the
unified-reduction-strategies
branch
from
ef1a3b9
to
422e17f
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, the proposed syntax has:
Rendered here.