Fix file upload #556

[ticruz38]

A few things here:

• The loading state was no longer bound to editorLoading in NoteReply, this allowed us to send a reply while a file was being uploaded, NoteCreate editor was instantiated correctly so that we could NOT send a note while a file was being uploaded.
• The blossom endpoint that we use by default (cdn.satellite.earth) has a very low free tier, after 2 uploads, it returns an error (payment required)
• If a file upload returns an error, the editor loads forever, we need to catch those errors and update the editor content accordingly
• When saving a draft, if a file is being uploaded, the blob will be saved and never resolved to its actual upload URL

[ticruz38]

The last 2 points would be worth a PR in nostr-editor eventually.
It can be fixed in Coracle too, but with some convoluted tiptap code.

[staab]

That all makes sense, we've needed to add errors to file uploads for a long time. Is there a way to get the error from nostr-editor when an upload fails and show it? Feel free to approach this problem however you like, either via PR to nostr-editor/@welshman/editor or directly here.

[ticruz38]

At the time the only blossom endpoint working was cdn.satellite.earth, all others endpoint were CORs protected. Probably still the case but it would be nice to take another round and see if one blossom provider is somehow more generous than satellite.

• Handle error with a message

• Clean up blobs before saving draft and once an error is returned.

• A PR is opened to add a removeBlobs command to the fileUpload extension in nostr-editor.

[staab]

This should work fine, but ideally it would be targeted to the specific file that failed. Otherwise, if there are multiple concurrent uploads and one fails, the other will get removed as well too right?

[ticruz38]

Yes that's right, onUploadFail gives me the file that failed so it should be possible to remove just this one

[ticruz38]

nostr-editor keep an uploadError attribute on each node. I have added an errorsOnly attribute to the removeBlobs command that will only remove blobs in an error state.

[ticruz38]

• use toast to display upload error
• add an option to only remove blobs in error state

[ticruz38]

once the PR is merged in nostr-editor, we will be able to remove some code here too.