Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
avantgardnerio committed Oct 7, 2024
1 parent d18c05b commit 369045d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion datafusion/physical-plan/src/execution_plan.rs
Original file line number Diff line number Diff line change
Expand Up @@ -908,7 +908,7 @@ pub fn get_plan_string(plan: &Arc<dyn ExecutionPlan>) -> Vec<String> {
pub enum CardinalityEffect {
/// Unknown effect. This is the default
Unknown,
/// The operator is guaranteed to produce exactly one row for
/// The operator is guaranteed to produce exactly one row for
/// each input row
Equal,
/// The operator may produce fewer output rows than it receives input rows
Expand Down
6 changes: 5 additions & 1 deletion datafusion/physical-plan/src/sorts/sort.rs
Original file line number Diff line number Diff line change
Expand Up @@ -975,7 +975,11 @@ impl ExecutionPlan for SortExec {
}

fn cardinality_effect(&self) -> CardinalityEffect {
CardinalityEffect::Equal
if self.fetch.is_none() {
CardinalityEffect::Equal
} else {
CardinalityEffect::LowerEqual
}
}
}

Expand Down

0 comments on commit 369045d

Please sign in to comment.