Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-15747: Add db to topic permissions #1189

Merged
merged 11 commits into from
Aug 17, 2023

Conversation

BenYip123
Copy link
Contributor

@BenYip123 BenYip123 commented Jul 26, 2023

  • add db worker producer topic permissions to: membership.async.request, membership.registration, membership.db.rpc.ops
  • add db worker consumer topic permission to membership.db.rpc.ops.resp

Related changes in corda-runtime-os: CORE-15747: Re-register member when upgrading vNode #4380
Enable test in corda-e2e-tests: CORE-15747: Enable virtual node upgrade updates CPI info in the MGM test #177

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Jul 26, 2023

Non-blocking downstream job failed for corda-e2e-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1189/2/ has failed for PR 1189 build 2

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Jul 26, 2023

Jenkins build for PR 1189 build 23

Build Successful:
Jar artifact version produced by this PR: 5.1.0.13-alpha-1692194498910

@BenYip123 BenYip123 force-pushed the benyip/CORE-15747/add-db-topic-permission branch from 95a941a to c2478d3 Compare July 28, 2023 16:21
@BenYip123 BenYip123 marked this pull request as ready for review July 28, 2023 16:41
@BenYip123 BenYip123 requested review from a team July 28, 2023 16:42
Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but a change is needed as suggested.

@vkolomeyko vkolomeyko requested a review from a team July 28, 2023 17:16
@BenYip123 BenYip123 force-pushed the benyip/CORE-15747/add-db-topic-permission branch from ff44f8c to 90e5347 Compare July 31, 2023 08:47
@BenYip123 BenYip123 force-pushed the benyip/CORE-15747/add-db-topic-permission branch 2 times, most recently from 9031d07 to 8a76267 Compare August 2, 2023 09:02
@BenYip123 BenYip123 force-pushed the benyip/CORE-15747/add-db-topic-permission branch 2 times, most recently from 3b20e45 to eb1bc07 Compare August 4, 2023 08:29
@BenYip123 BenYip123 force-pushed the benyip/CORE-15747/add-db-topic-permission branch from 4809c9b to 666a426 Compare August 10, 2023 15:49
@BenYip123 BenYip123 force-pushed the benyip/CORE-15747/add-db-topic-permission branch from f0c7cb5 to 4758898 Compare August 16, 2023 13:11
@BenYip123 BenYip123 changed the title CORE-15747: Add db to topic permission CORE-15747: Add db to topic permissions Aug 16, 2023
Copy link
Contributor

@nikinagy nikinagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenYip123 BenYip123 merged commit a76c4ea into release/os/5.1 Aug 17, 2023
4 checks passed
@BenYip123 BenYip123 deleted the benyip/CORE-15747/add-db-topic-permission branch August 17, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants