Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES-1061: use correct version of shared pipeline along with correct JDK #1198

Merged
merged 1 commit into from
Aug 3, 2023
Merged

ES-1061: use correct version of shared pipeline along with correct JDK #1198

merged 1 commit into from
Aug 3, 2023

Conversation

ronanbrowne
Copy link
Contributor

  • Ensure windows nightly use correct shared lib version + override correct JDK

@ronanbrowne ronanbrowne requested a review from a team as a code owner August 3, 2023 13:31
mcgovc
mcgovc approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@mcgovc mcgovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corda-jenkins-ci02
Copy link
Contributor

Jenkins build for PR 1198 build 1

Build Successful:
Jar artifact version produced by this PR: 5.1.0.12-alpha-1691069496564

@ronanbrowne ronanbrowne merged commit bba7588 into release/os/5.1 Aug 3, 2023
3 checks passed
@ronanbrowne ronanbrowne deleted the ES-1061-Ensure-windows-nightly-jobs-use-J17-for-5.1 branch August 3, 2023 13:50
yarivus
yarivus reviewed Aug 3, 2023
View reviewed changes
Copy link
Contributor

@yarivus yarivus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @ronanbrowne

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarivus yarivus yarivus left review comments

@mcgovc mcgovc mcgovc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronanbrowne @mcgovc @yarivus