Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-15586 Split verification from TransactionSignatureService into TransactionSignatureVerificationService #1206

Conversation

vlajos
Copy link
Contributor

@vlajos vlajos commented Aug 11, 2023

CORE-15586 Split verification from TransactionSignatureService into TransactionSignatureVerificationService to let it be injected separately in the verification sandbox. That way, we can keep the verification sandbox more streamlined.

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Aug 11, 2023

Jenkins build for PR 1206 build 3

Build Successful:
Jar artifact version produced by this PR: 5.1.0.14-alpha-1692287969040

@vlajos vlajos force-pushed the vlajos/CORE-15586-transactionsignatureservice-in-verification branch from a964177 to 4596c59 Compare August 17, 2023 15:59
@vlajos vlajos marked this pull request as ready for review August 17, 2023 16:01
@vlajos vlajos requested a review from a team as a code owner August 17, 2023 16:01
@vlajos vlajos requested review from blsemo and a team August 17, 2023 16:01
Copy link
Contributor

@blsemo blsemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vlajos vlajos merged commit a54ecd3 into release/os/5.1 Aug 18, 2023
2 checks passed
@vlajos vlajos deleted the vlajos/CORE-15586-transactionsignatureservice-in-verification branch August 18, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants