Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-15757 flow session refactor #1208

Merged
merged 20 commits into from
Sep 1, 2023

Conversation

LWogan
Copy link
Contributor

@LWogan LWogan commented Aug 11, 2023

Flow Session Refactor to reduce the total messages exchanged between session counterparties.

SessionInit info can now be piggybacked onto SessionData messages.

SessionAcks are removed.

SessionContextProperties are piggybacked onto any SessionEvents as SessionConfirm is not always sent.

Add new initiateFlow API to allow the initiator to define whether a SessionClose message should be sent by the initiated party when their flow finishes or when they call close. Whichever comes first.

Runtime-OS:
corda/corda-runtime-os#4446
E2E Tests
https://github.com/corda/corda-e2e-tests/pull/218

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Aug 11, 2023

Non-blocking downstream job failed for corda-e2e-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1208/13/ has failed for PR 1208 build 13

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Aug 11, 2023

Jenkins build for PR 1208 build 19

Build Successful:
Jar artifact version produced by this PR: 5.1.0.18-alpha-1693567290509

@LWogan
Copy link
Contributor Author

LWogan commented Aug 14, 2023

@chrisr3 as mentioned in the draft text this PR is not for review yet

@chrisr3
Copy link
Contributor

chrisr3 commented Aug 14, 2023

@chrisr3 as mentioned in the draft text this PR is not for review yet

This change looks like something unexpected that is difficult just to ignore...

@LWogan
Copy link
Contributor Author

LWogan commented Aug 14, 2023

@chrisr3 as mentioned in the draft text this PR is not for review yet

This change looks like something unexpected that is difficult just to ignore...

I may have made some updates this morning.... completely unrelated to your comments.... 👀

LWogan and others added 6 commits August 16, 2023 11:40
…E-15757/flow-session-refactor

# Conflicts:
#	gradle.properties
…E-15757/flow-session-refactor

# Conflicts:
#	gradle.properties
…E-15757/flow-session-refactor

# Conflicts:
#	gradle.properties
…t so it can be set both directions (#1212)

Remove config fields not used anymore.
counterparty lookups are no longer retriable.
Session events are not resent.
@LWogan LWogan changed the title CORE-15757 WIP: flow session refactor CORE-15757 flow session refactor Aug 30, 2023
…E-15757/flow-session-refactor

# Conflicts:
#	gradle.properties
JamesHR3
JamesHR3 previously approved these changes Sep 1, 2023
JamesHR3
JamesHR3 previously approved these changes Sep 1, 2023
@LWogan LWogan merged commit 9ea9852 into release/os/5.1 Sep 1, 2023
2 checks passed
@LWogan LWogan deleted the feature/CORE-15757/flow-session-refactor branch September 1, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants