Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-16174 move session context props from SessionInit to SessionEvent so it can be set both directions #1212

Conversation

LWogan
Copy link
Contributor

@LWogan LWogan commented Aug 14, 2023

Remove config fields not used anymore.
counterparty lookups are no longer retriable.
Session events are not resent.

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Aug 14, 2023

Jenkins build for PR 1212 build 15

Build Successful:
Jar artifact version produced by this PR: 5.1.0.999-alpha-1693317538874

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Aug 14, 2023

Non-blocking downstream job failed for corda-e2e-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1212/11/ has failed for PR 1212 build 11

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests

@LWogan LWogan changed the title CORE-16174 move session context props from init to data so it can be set both directions CORE-16174 WIP:move session context props from init to data so it can be set both directions Aug 16, 2023
@LWogan LWogan changed the title CORE-16174 WIP:move session context props from init to data so it can be set both directions CORE-16174 move session context props from init to data so it can be set both directions Aug 23, 2023
@LWogan LWogan marked this pull request as ready for review August 23, 2023 13:19
@LWogan LWogan requested a review from a team as a code owner August 23, 2023 13:19
@LWogan LWogan changed the title CORE-16174 move session context props from init to data so it can be set both directions CORE-16174 move session context props from SessionInit to SessionEvent so it can be set both directions Aug 23, 2023
@LWogan LWogan merged commit 31810fb into feature/CORE-15757/flow-session-refactor Aug 30, 2023
@LWogan LWogan deleted the CORE-16174/session-init-data-refactor branch August 30, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant