Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-15069 move flow to components #4164

Merged
merged 4 commits into from
Aug 23, 2023
Merged

CORE-15069 move flow to components #4164

merged 4 commits into from
Aug 23, 2023

Conversation

emilybowe
Copy link
Contributor

Move two flow modules from libs to components. This will be used in future work to make use of a membership service in components to check clusters are local. Moving or copying this service was considered also but the move is also suggested for better design as these modules are closer to components than libs.

@emilybowe emilybowe added the enhancement New feature or request label Jun 27, 2023
@emilybowe emilybowe requested a review from mnesbit as a code owner June 27, 2023 13:31
@emilybowe emilybowe self-assigned this Jun 27, 2023
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Jun 28, 2023 •
edited
Loading

Jenkins build for PR 4164 build 15

Build Successful:
Jar artifact version produced by this PR: 5.1.0.0-alpha-1692264817481
Helm chart version produced by this PR: 5.1.0-alpha.1692264817481
Helm chart pushed to: corda-os-docker-dev.software.r3.com/helm-charts/pr-4164/corda

ben-millar
ben-millar previously approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@ben-millar ben-millar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  _____       ______  _________  ____    ____  
 |_   _|    .' ___  ||  _   _  ||_   \  /   _| 
   | |     / .'   \_||_/ | | \_|  |   \/   |   
   | |   _ | |   ____    | |      | |\  /| |   
  _| |__/ |\ `.___]  |  _| |_    _| |_\/_| |_  
 |________| `._____.'  |_____|  |_____||_____|

@thiagoviana thiagoviana requested a review from a team June 28, 2023 13:00
@emilybowe emilybowe changed the title CORE-14523 move flow to components CORE-15069 move flow to components Jun 28, 2023
ronanbrowne
ronanbrowne previously approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@ronanbrowne ronanbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (build files changes only reviewed )

@thiagoviana
Copy link
Contributor

As agreed, we're moving this to a feature branch, not 5.0 or 5.1.

@emilybowe
Copy link
Contributor Author

emilybowe commented Jul 3, 2023 •
edited
Loading

Keeping this work in a feature branch for now, to avoid merging into 5.0 where possible. @thiagoviana

@emilybowe emilybowe marked this pull request as draft July 3, 2023 09:48
@emilybowe emilybowe force-pushed the CORE-14523_move_flow_to_components branch from a1c3e45 to 326feb4 Compare July 3, 2023 09:52
@emilybowe emilybowe force-pushed the CORE-14523_move_flow_to_components branch from 326feb4 to 894ae41 Compare July 12, 2023 10:37
@emilybowe emilybowe force-pushed the CORE-14523_move_flow_to_components branch from 112198b to bdfd325 Compare August 1, 2023 10:59
@ben-millar ben-millar dismissed stale reviews from ronanbrowne and themself via f939f92 August 2, 2023 09:28
@ben-millar ben-millar force-pushed the CORE-14523_move_flow_to_components branch from bdfd325 to f939f92 Compare August 2, 2023 09:28
@emilybowe emilybowe force-pushed the CORE-14523_move_flow_to_components branch 2 times, most recently from 24949b1 to 7669760 Compare August 11, 2023 14:12
@emilybowe emilybowe changed the base branch from release/os/5.0 to release/os/5.1 August 14, 2023 10:25
@emilybowe emilybowe force-pushed the CORE-14523_move_flow_to_components branch from 7669760 to 7c885ea Compare August 15, 2023 10:52
LWogan
LWogan approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@LWogan LWogan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. When ready, merge this to feature/CORE-15757/flow-session-refactor

@LWogan LWogan changed the base branch from release/os/5.1 to feature/CORE-15757/flow-session-refactor August 17, 2023 08:40
@LWogan LWogan marked this pull request as ready for review August 17, 2023 10:48
@LWogan LWogan requested a review from a team as a code owner August 17, 2023 10:48
wzur-r3
wzur-r3 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@wzur-r3 wzur-r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Gradle file change

@LWogan LWogan merged commit 237ee69 into feature/CORE-15757/flow-session-refactor Aug 23, 2023
@LWogan LWogan deleted the CORE-14523_move_flow_to_components branch August 23, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzur-r3 wzur-r3 wzur-r3 approved these changes

@LWogan LWogan LWogan approved these changes

@ronanbrowne ronanbrowne ronanbrowne left review comments

@ben-millar ben-millar ben-millar left review comments

@mnesbit mnesbit Awaiting requested review from mnesbit

@driessamyn driessamyn Awaiting requested review from driessamyn

@rick-r3 rick-r3 Awaiting requested review from rick-r3

@fenryka fenryka Awaiting requested review from fenryka

@yarivus yarivus Awaiting requested review from yarivus

Assignees

@emilybowe emilybowe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@emilybowe @thiagoviana @ronanbrowne @ben-millar @wzur-r3 @LWogan