Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES-2299: Remove the old rest-client module #6208

Merged
merged 1 commit into from
Jun 13, 2024
Merged

ES-2299: Remove the old rest-client module #6208

merged 1 commit into from
Jun 13, 2024

Conversation

tlawson3
Copy link
Contributor

After we added the generated-rest-client the old rest-client isn't being used in the CLI anymore

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@corda-jenkins-ci02
Copy link
Contributor

Jenkins build for PR 6208 build 2

Build Successful:
Jar artifact version produced by this PR: 5.3.0.0-alpha-1718272515969
Helm chart version produced by this PR: 5.3.0-alpha.1718272515969
Helm chart pushed to: oci://corda-os-docker-dev.software.r3.com/helm-charts/pr-6208/corda
Helm chart Polaris score: 82

@tlawson3
Copy link
Contributor Author

build e2e

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Jun 13, 2024 •
edited
Loading

Building E2E Tests on PR-6208

Succeeded

@tlawson3 tlawson3 marked this pull request as ready for review June 13, 2024 12:39
@tlawson3 tlawson3 requested review from a team as code owners June 13, 2024 12:39
anton-subbotin
anton-subbotin approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@anton-subbotin anton-subbotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Tooling team)

wzur-r3
wzur-r3 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@wzur-r3 wzur-r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved changes for Gradle settings file

vkolomeyko
vkolomeyko approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlawson3 tlawson3 merged commit a2a6d65 into release/os/5.3 Jun 13, 2024
8 checks passed
@tlawson3 tlawson3 deleted the tlawson/ES-2299/removeOldRestClient branch June 13, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkolomeyko vkolomeyko vkolomeyko approved these changes

@wzur-r3 wzur-r3 wzur-r3 approved these changes

@anton-subbotin anton-subbotin anton-subbotin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tlawson3 @vkolomeyko @wzur-r3 @anton-subbotin