Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-20708 Wait for the cluster to be ready before sending REST calls in E2E tests #6210

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

LWogan
Copy link
Contributor

@LWogan LWogan commented Jun 14, 2024

This will ensure config has propagated through the system. Currently the tests wait until the client stops throwing exceptions when trying to connect to the REST worker to detect that its back up, This results in some strange timing issues which affect test stability

…. This will ensure config has propagated through the system
…. This will ensure config has propagated through the system
@LWogan LWogan changed the title CORE-20708 config update check cluster CORE-20708 Wait for the cluster to be ready before sending REST calls Jun 14, 2024
Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@LWogan LWogan changed the title CORE-20708 Wait for the cluster to be ready before sending REST calls CORE-20708 Wait for the cluster to be ready before sending REST calls in E2E tests Jun 14, 2024
@LWogan
Copy link
Contributor Author

LWogan commented Jun 14, 2024

This change has no impact on functionality. It is confined to a test library that is shared with the E2E test repo/pipelines.

@corda-jenkins-ci02
Copy link
Contributor

Jenkins build for PR 6210 build 1

Build Successful:
Jar artifact version produced by this PR: 5.2.1.0-alpha-1718371461250
Helm chart version produced by this PR: 5.2.1-alpha.1718371461250
Helm chart pushed to: oci://corda-os-docker-dev.software.r3.com/helm-charts/pr-6210/corda
Helm chart Polaris score: 82

Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ben-millar ben-millar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ronanbrowne ronanbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LWogan LWogan merged commit 0bcf939 into release/os/5.2 Jun 17, 2024
8 checks passed
@LWogan LWogan deleted the lorcanw/CORE-20708/config-update-check-cluster branch June 17, 2024 09:10
emilybowe pushed a commit that referenced this pull request Jun 25, 2024
emilybowe added a commit that referenced this pull request Jun 26, 2024
… in E2E tests (#6210) (#6228)

Co-authored-by: Lorcan Wogan <[email protected]>
This will ensure config has propagated through the system. Currently the tests wait until the client stops throwing exceptions when trying to connect to the REST worker to detect that its back up, This results in some strange timing issues which affect test stability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants