Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-8415 - Upgrade Javalin to version 6.2.0 #6211

Merged
merged 70 commits into from
Jul 23, 2024
Merged

CORE-8415 - Upgrade Javalin to version 6.2.0 #6211

merged 70 commits into from
Jul 23, 2024

Conversation

filipesoliveira
Copy link
Contributor

@filipesoliveira filipesoliveira commented Jun 14, 2024 •
edited by vkolomeyko
Loading

This PR depends on:

TODO list:

  • 1) Once the PR is green, the e2e tests must be run. (Done.)
  • 2) Once the e2e tests are green, the Q.A. regression tests must be run. (Done.)
  • 3) Once all tests are green, remove the temporary repo that was added for testing purposes. (Done.)
  • 4) Update the Javalin version to point to an official release instead of a snapshot. (Done. Javalin 6.2.0.)

@filipesoliveira filipesoliveira requested review from a team as code owners June 14, 2024 15:32
@vkolomeyko

This comment was marked as outdated.

Sign in to view
@vkolomeyko vkolomeyko marked this pull request as draft June 17, 2024 08:39
@vkolomeyko vkolomeyko requested a review from a team June 17, 2024 08:48
@filipesoliveira filipesoliveira force-pushed the filipe.oliveira/CORE-8415 branch 2 times, most recently from 8aee1fe to 3115dd4 Compare June 18, 2024 11:02
@vkolomeyko vkolomeyko added the WIP label Jun 19, 2024
@vkolomeyko vkolomeyko requested a review from a team June 19, 2024 08:17
@filipesoliveira filipesoliveira force-pushed the filipe.oliveira/CORE-8415 branch 2 times, most recently from e7515f0 to 1daa65e Compare June 25, 2024 10:59
filipesoliveira
filipesoliveira commented Jun 25, 2024
View reviewed changes
gradle.properties Outdated Show resolved Hide resolved
filipesoliveira
filipesoliveira commented Jun 26, 2024
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
@vkolomeyko vkolomeyko changed the title CORE-8415 - Upgrade Javalin to version 6.1.3 CORE-8415 - Upgrade Javalin to version 6.1.7 Jul 1, 2024
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Jul 2, 2024 •
edited
Loading

Jenkins build for PR 6211 build 83

Build Successful:
Jar artifact version produced by this PR: 5.3.0.0-alpha-1721740282726
Helm chart version produced by this PR: 5.3.0-alpha.1721740282726
Helm chart pushed to: oci://corda-os-docker-dev.software.r3.com/helm-charts/pr-6211/corda
Helm chart Polaris score: 82

@filipesoliveira
Copy link
Contributor Author

build e2e

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Jul 2, 2024 •
edited
Loading

Building E2E Tests on PR-6211

Succeeded

@filipesoliveira
Copy link
Contributor Author

build e2e

@filipesoliveira
Copy link
Contributor Author

build e2e

1 similar comment
@filipesoliveira
Copy link
Contributor Author

build e2e

@vkolomeyko vkolomeyko changed the title CORE-8415 - Upgrade Javalin to version 6.1.7 CORE-8415 - Upgrade Javalin to version 6.2.0 Jul 22, 2024
@filipesoliveira filipesoliveira marked this pull request as ready for review July 22, 2024 16:57
@filipesoliveira filipesoliveira requested a review from a team as a code owner July 22, 2024 16:57
tlawson3
tlawson3 previously approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@tlawson3 tlawson3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Tooling files

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@filipesoliveira
Copy link
Contributor Author

build e2e

vkolomeyko
vkolomeyko approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tlawson3
tlawson3 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@tlawson3 tlawson3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tooling

@filipesoliveira filipesoliveira merged commit f78fe82 into release/os/5.3 Jul 23, 2024
7 checks passed
@filipesoliveira filipesoliveira deleted the filipe.oliveira/CORE-8415 branch July 23, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkolomeyko vkolomeyko vkolomeyko approved these changes

@tlawson3 tlawson3 tlawson3 approved these changes

Assignees
No one assigned
Labels
DO_NOT_CLOSE WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filipesoliveira @vkolomeyko @tlawson3