CORE-20731: Implement DeleteUser endpoint #6224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins build for PR 6224 build 6 Build Successful: |
BenYip123
commented
Jun 27, 2024
vkolomeyko
reviewed
Jun 27, 2024
| * @param loginName The login name of the user to be deleted. | ||
| * @param user The user to be published. | ||
| */ | ||
| fun publishDeletedUser(loginName: String, user: AvroUser?) |
There was a problem hiding this comment.
I wonder if we ever going to pass a non-null AvroUser to this method?
If not, it would probably make more sense:
Suggested change
| fun publishDeletedUser(loginName: String, user: AvroUser?) | |
| fun publishDeletedUser(loginName: String) |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corda-api changes: corda/corda-api#1663
e2e-test changes: https://github.com/corda/corda-e2e-tests/pull/663