Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES-2402: Use generated models in rest client #6225

Merged
merged 13 commits into from
Jun 25, 2024
Merged

ES-2402: Use generated models in rest client #6225

merged 13 commits into from
Jun 25, 2024

Conversation

anton-subbotin
Copy link
Contributor

@anton-subbotin anton-subbotin commented Jun 24, 2024 •
edited
Loading

ES-2402

  • Remove all importMappings to the existing and custom DTOs and use only generated models instead
  • Remove jsr310 dependency - generated models do not deal with Instant type
  • Remove Gradle dependencies on inner projects

github-actions[bot]
github-actions bot previously requested changes Jun 24, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title failed to match regex -> ^((CORDA|EG|ENT|INFRA|CORE|DOC|ES|DA5|DI)-\d+)(.*)

@anton-subbotin anton-subbotin changed the title Asubbotin/es 2402/generated client use generated models ES-2402: Use generated models in rest client Jun 24, 2024
@github-actions github-actions bot dismissed their stale review June 24, 2024 16:03

All good!

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Jun 24, 2024 •
edited
Loading

Jenkins build for PR 6225 build 9

Build Successful:
Jar artifact version produced by this PR: 5.3.0.0-alpha-1719326157411
Helm chart version produced by this PR: 5.3.0-alpha.1719326157411
Helm chart pushed to: oci://corda-os-docker-dev.software.r3.com/helm-charts/pr-6225/corda
Helm chart Polaris score: 82

@anton-subbotin
Copy link
Contributor Author

build e2e

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Jun 24, 2024 •
edited
Loading

Building E2E Tests on PR-6225

Build Failed: https://ci02.dev.r3.com/job/Corda5/job/corda-rebuild-e2e-tests/job/PR-6225/3/

@anton-subbotin
Copy link
Contributor Author

E2E tests using 5.3.0.0-alpha-1719248309321 version of Corda CLI: https://ci02.dev.r3.com/blue/organizations/jenkins/Corda5%2Fcorda5-e2e-tests/detail/PR-662/3/pipeline/
(PR: https://github.com/corda/corda-e2e-tests/pull/662/files)

@anton-subbotin
Copy link
Contributor Author

anton-subbotin commented Jun 25, 2024 •
edited
Loading

E2E tests using 5.3.0.0-alpha-1719306441163 version of Corda CLI (removed jsr310 dependency): https://ci02.dev.r3.com/blue/organizations/jenkins/Corda5%2Fcorda5-e2e-tests/detail/PR-662/4/pipeline/
(PR: https://github.com/corda/corda-e2e-tests/pull/662/files)

@anton-subbotin anton-subbotin marked this pull request as ready for review June 25, 2024 11:32
@anton-subbotin anton-subbotin requested review from a team as code owners June 25, 2024 11:32
tlawson3
tlawson3 previously approved these changes Jun 25, 2024
View reviewed changes
YashNabar
YashNabar previously approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@YashNabar YashNabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (network-team files)

williamvigorr3
williamvigorr3 previously approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@williamvigorr3 williamvigorr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Network team files

vkolomeyko
vkolomeyko reviewed Jun 25, 2024
View reviewed changes
libs/rest/generated-rest-client/build.gradle Outdated
@@ -96,7 +32,6 @@ dependencies {
implementation libs.kotlin.stdlib
implementation libs.jackson.dataformat.yaml
implementation libs.jackson.databind
implementation libs.jackson.datatype.jsr310
implementation libs.jackson.module.kotlin
implementation libs.okHttp
implementation project(':components:crypto:crypto-rest')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we ought to challenge all those dependencies below and potentially delete some/all of them.
Ideally, generated client should not depend on anything project(.*rest.*) and be produced just from swaggerBaseline.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@vkolomeyko vkolomeyko self-requested a review June 25, 2024 14:55
vkolomeyko
vkolomeyko approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anton-subbotin anton-subbotin merged commit 3fb6c98 into release/os/5.3 Jun 25, 2024
8 checks passed
@anton-subbotin anton-subbotin deleted the asubbotin/ES-2402/generated-client-use-generated-models branch June 25, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkolomeyko vkolomeyko vkolomeyko approved these changes

@tlawson3 tlawson3 tlawson3 approved these changes

@YashNabar YashNabar YashNabar left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@williamvigorr3 williamvigorr3 williamvigorr3 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anton-subbotin @YashNabar @vkolomeyko @williamvigorr3 @tlawson3