Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-20738 Close the registration before closing the subscription #6229

Conversation

williamvigorr3
Copy link
Contributor

@williamvigorr3 williamvigorr3 commented Jun 25, 2024

This fixes a spurious error in the logs about a registration not being closed.

@williamvigorr3 williamvigorr3 changed the title Close the registration before closing the subscription CORE-20738 Close the registration before closing the subscription Jun 25, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title failed to match regex -> ^((CORDA|EG|ENT|INFRA|CORE|DOC|ES|DA5|DI)-\d+)(.*)

@github-actions github-actions bot dismissed their stale review June 25, 2024 15:36

All good!

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Jun 25, 2024

Jenkins build for PR 6229 build 4

Build Successful:
Jar artifact version produced by this PR: 5.3.0.0-alpha-1719938002107
Helm chart version produced by this PR: 5.3.0-alpha.1719938002107
Helm chart pushed to: oci://corda-os-docker-dev.software.r3.com/helm-charts/pr-6229/corda
Helm chart Polaris score: 82

@LWogan
Copy link
Contributor

LWogan commented Jun 26, 2024

Well spotted! That wasn't an easy one to figure out!

@williamvigorr3 williamvigorr3 changed the base branch from release/os/5.2 to release/os/5.3 July 2, 2024 15:59
Copy link

sonarcloud bot commented Jul 2, 2024

Copy link
Contributor

@YashNabar YashNabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamvigorr3 williamvigorr3 marked this pull request as ready for review July 3, 2024 08:43
@williamvigorr3 williamvigorr3 merged commit 616bf3d into release/os/5.3 Jul 3, 2024
7 checks passed
@williamvigorr3 williamvigorr3 deleted the WillV/CORE-20738-Fix-Registration-not-closed-error branch July 3, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants